Bug 1559099: Don't check metadata for JumpTableEntry instructions; r=lth
authorBenjamin Bouvier <benj@benj.me>
Wed, 26 Jun 2019 18:02:58 +0200
changeset 543614 b684d4532b91357024ec0ac6810565d442bc54f3
parent 543613 e73151bcaff8a776ee5536da1dbe6e6b91799032
child 543615 f3b972e5914eca062d19dbaaed110e5472b7b612
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslth
bugs1559099
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1559099: Don't check metadata for JumpTableEntry instructions; r=lth Differential Revision: https://phabricator.services.mozilla.com/D36328
js/src/wasm/cranelift/src/compile.rs
--- a/js/src/wasm/cranelift/src/compile.rs
+++ b/js/src/wasm/cranelift/src/compile.rs
@@ -263,17 +263,17 @@ impl<'a, 'b> BatchCompiler<'a, 'b> {
                     | ir::Opcode::Istore8Complex
                     | ir::Opcode::Istore16
                     | ir::Opcode::Istore16Complex
                     | ir::Opcode::Istore32
                     | ir::Opcode::Istore32Complex => self.memory_metadata(metadata, inst, offset),
 
                     // Instructions that are not going to trap in our use, even though their opcode
                     // says they can.
-                    ir::Opcode::Spill | ir::Opcode::Fill => {}
+                    ir::Opcode::Spill | ir::Opcode::Fill | ir::Opcode::JumpTableEntry => {}
 
                     _ if BatchCompiler::platform_specific_ignores_metadata(opcode) => {}
 
                     _ => {
                         debug_assert!(!opcode.is_call(), "Missed call opcode");
                         debug_assert!(
                             !opcode.can_trap(),
                             "Missed trap: {}",