Bug 1037754: Must always use SyncRunnable for DISPATCH_SYNC on non-nsThreads or risk leaks r=drno
authorRandell Jesup <rjesup@jesup.org>
Thu, 17 Jul 2014 03:08:38 -0400
changeset 216478 b623f53cdac13f68b8faea2d430192c952592fe3
parent 216477 c259eb48968020f6ae04ffed8832054c3f4ecba8
child 216479 8c9c9a6c39346cb4ea22cafbba6abf4d1158cbf0
push id515
push userraliiev@mozilla.com
push dateMon, 06 Oct 2014 12:51:51 +0000
treeherdermozilla-release@267c7a481bef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdrno
bugs1037754
milestone33.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1037754: Must always use SyncRunnable for DISPATCH_SYNC on non-nsThreads or risk leaks r=drno
media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp
--- a/media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp
+++ b/media/webrtc/signaling/src/media/VcmSIPCCBinding.cpp
@@ -262,19 +262,18 @@ bool VcmSIPCCBinding::scanForGmpCodecs()
   // XXX We shouldn't be blocking MainThread on the GMP thread!
   // This initiates the scan for codecs
   nsCOMPtr<nsIThread> thread;
   nsresult rv = gSelf->mGMPService->GetThread(getter_AddRefs(thread));
   if (NS_FAILED(rv)) {
     return false;
   }
   // presumes that all GMP dir scans have been queued for the GMPThread
-  RUN_ON_THREAD(thread,
-                WrapRunnableNM(&GMPDummy),
-                NS_DISPATCH_SYNC);
+  mozilla::SyncRunnable::DispatchToThread(thread,
+                                          WrapRunnableNM(&GMPDummy));
   return true;
 }
 
 int VcmSIPCCBinding::getVideoCodecsGmp()
 {
   if (!gInitGmpCodecs) {
     if (scanForGmpCodecs()) {
       gInitGmpCodecs = true;