Bug 1457139 [wpt PR 10657] - Align Request.destination to spec, a=testonly
authorYoav Weiss <yoav@yoav.ws>
Tue, 01 May 2018 15:46:55 +0000
changeset 472688 b60142c1cc9a01efbb27b591c1828015ffa0a6cb
parent 472687 bfc1a530e1c8cc210e2ad9fc866c3caeb4b2ec4d
child 472689 eacd312dd4c62c177e30f73d2e1c204cf8b7ce82
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1457139, 10657, 832105, 1029858, 554341
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457139 [wpt PR 10657] - Align Request.destination to spec, a=testonly Automatic update from web-platform-testsAlign Request.destination to spec Currently `Request.destination` is set to "unknown" prefetch, but that was recently changed: Issue: https://github.com/whatwg/fetch/issues/658 PR: https://github.com/whatwg/fetch/pull/659 This CL aligns the destination values to the spec change. Bug: 832105 Change-Id: Ib9f21dcc6cf0ace27b7a810d3670cddc45b3b74f Reviewed-on: https://chromium-review.googlesource.com/1029858 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554341} -- wpt-commits: 3c940291e9e8c30e8c7c401426160e3531639403 wpt-pr: 10657
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/fetch/api/request/destination/fetch-destination.https.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -558224,17 +558224,17 @@
    "343618faf06d5809b0f782191566b36037277c31",
    "testharness"
   ],
   "fetch/api/request/destination/fetch-destination-worker.https.html": [
    "65fc76503d95a359bf2fafebe603aa19bd0a2bfb",
    "testharness"
   ],
   "fetch/api/request/destination/fetch-destination.https.html": [
-   "5b7276e8a10bf91ee7d2a92917176b8e62c3255d",
+   "29e22bbe11b501fa354e90dde671f5f500fcaab3",
    "testharness"
   ],
   "fetch/api/request/destination/resources/dummy": [
    "da39a3ee5e6b4b0d3255bfef95601890afd80709",
    "support"
   ],
   "fetch/api/request/destination/resources/dummy.es": [
    "da39a3ee5e6b4b0d3255bfef95601890afd80709",
--- a/testing/web-platform/tests/fetch/api/request/destination/fetch-destination.https.html
+++ b/testing/web-platform/tests/fetch/api/request/destination/fetch-destination.https.html
@@ -420,9 +420,23 @@ promise_test(async t => {
       node.onerror = reject;
       node.href = "dummy?dest=manifest";
       frame.contentWindow.document.body.appendChild(node);
   }).catch(() => {
       assert_unreached("Fetch errored.");
   });
 }, 'HTMLLinkElement with rel=preload and as=manifest fetches with a "manifest" Request.destination');
 
+// HTMLLinkElement with rel=prefetch - empty string destination
+promise_test(async t => {
+  await new Promise((resolve, reject) => {
+      let node = frame.contentWindow.document.createElement("link");
+      node.rel = "prefetch";
+      node.onload = resolve;
+      node.onerror = reject;
+      node.href = "dummy?dest=";
+      frame.contentWindow.document.body.appendChild(node);
+  }).catch(() => {
+      assert_unreached("Fetch errored.");
+  });
+}, 'HTMLLinkElement with rel=prefetch fetches with an empty string Request.destination');
+
 </script>