Bug 1144629 - UnicodeDecodeError in ./mach mercurial-setup. r=gps, r=glandium
authorStéphane SCHMIDELY <stephanichous@hotmail.fr>
Wed, 25 Mar 2015 12:25:49 +0100
changeset 266182 b53d8a0d5645af2f740487d11ce3b2e25141bb0f
parent 266181 6f3151d4ff03c0bb1924e121fbef87d3696d5724
child 266183 36f19d3140edad28922804909c9c5c92a6721f9e
push id830
push userraliiev@mozilla.com
push dateFri, 19 Jun 2015 19:24:37 +0000
treeherdermozilla-release@932614382a68 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps, glandium
bugs1144629
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1144629 - UnicodeDecodeError in ./mach mercurial-setup. r=gps, r=glandium
tools/mercurial/hgsetup/wizard.py
--- a/tools/mercurial/hgsetup/wizard.py
+++ b/tools/mercurial/hgsetup/wizard.py
@@ -385,17 +385,17 @@ class MercurialSetupWizard(object):
     def can_use_extension(self, c, name, path=None):
         # Load extension to hg and search stdout for printed exceptions
         if not path:
             path = os.path.join(self.vcs_tools_dir, 'hgext', name)
         result = subprocess.check_output(['hg',
              '--config', 'extensions.testmodule=%s' % path,
              '--config', 'ui.traceback=true'],
             stderr=subprocess.STDOUT)
-        return "Traceback" not in result
+        return b"Traceback" not in result
 
     def prompt_external_extension(self, c, name, prompt_text, path=None):
         # Ask the user if the specified extension should be enabled. Defaults
         # to treating the extension as one in version-control-tools/hgext/
         # in a directory with the same name as the extension and thus also
         # flagging the version-control-tools repo as needing an update.
         if name not in c.extensions:
             if not self.can_use_extension(c, name, path):