Bug 1520014: Disable -Wc++11-narrowing in vixl under clang-cl. r=froydnj
authorDavid Major <dmajor@mozilla.com>
Wed, 23 Jan 2019 11:01:05 -0500
changeset 515130 b432f26c0035e67fdd8548680165af4717a2bdb6
parent 515129 459c4b6a47dd12cca50187e401dd1a7b474449bb
child 515131 cefe669c7351fc07d33f1c00979c81fdd7933d20
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1520014
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520014: Disable -Wc++11-narrowing in vixl under clang-cl. r=froydnj
js/src/jit/moz.build
--- a/js/src/jit/moz.build
+++ b/js/src/jit/moz.build
@@ -175,26 +175,32 @@ elif CONFIG['JS_CODEGEN_ARM64']:
         'arm64/CodeGenerator-arm64.cpp',
         'arm64/Lowering-arm64.cpp',
         'arm64/MacroAssembler-arm64.cpp',
         'arm64/MoveEmitter-arm64.cpp',
         'arm64/Trampoline-arm64.cpp',
         'arm64/vixl/Assembler-vixl.cpp',
         'arm64/vixl/Cpu-vixl.cpp',
         'arm64/vixl/Decoder-vixl.cpp',
-        'arm64/vixl/Disasm-vixl.cpp',
         'arm64/vixl/Instructions-vixl.cpp',
-        'arm64/vixl/Instrument-vixl.cpp',
         'arm64/vixl/MacroAssembler-vixl.cpp',
         'arm64/vixl/MozAssembler-vixl.cpp',
         'arm64/vixl/MozCpu-vixl.cpp',
         'arm64/vixl/MozInstructions-vixl.cpp',
         'arm64/vixl/Utils-vixl.cpp',
         'shared/AtomicOperations-shared-jit.cpp',
     ]
+    vixl_werror_sources = [
+        'arm64/vixl/Disasm-vixl.cpp',
+        'arm64/vixl/Instrument-vixl.cpp',
+    ]
+    SOURCES += vixl_werror_sources
+    if CONFIG['CC_TYPE'] == 'clang-cl':
+        for f in vixl_werror_sources:
+            SOURCES[f].flags += ['-Wno-c++11-narrowing']
     if CONFIG['JS_SIMULATOR_ARM64']:
         UNIFIED_SOURCES += [
             'arm64/vixl/Debugger-vixl.cpp',
             'arm64/vixl/Logic-vixl.cpp',
             'arm64/vixl/MozSimulator-vixl.cpp',
             'arm64/vixl/Simulator-vixl.cpp'
         ]
 elif CONFIG['JS_CODEGEN_MIPS32'] or CONFIG['JS_CODEGEN_MIPS64']: