Bug 1158387 - Remove "PRAGMA synchronous = OFF" to avoid corruption in cookie service. r=mak
☠☠ backed out by 538e29345b39 ☠ ☠
authorJunior Hsu <juhsu@mozilla.com>
Sun, 21 May 2017 18:48:00 -0400
changeset 413917 b2fe8f4df7010f229348fdd1da1459ec78617a39
parent 413916 b4b058bd7bcf9736b6d9cfb7fd2be7cc533c5339
child 413918 07b5b1e2ed4b665b6f01fc8a9d98faad65df5c21
push id1490
push usermtabara@mozilla.com
push dateMon, 31 Jul 2017 14:08:16 +0000
treeherdermozilla-release@70e32e6bf15e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmak
bugs1158387
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1158387 - Remove "PRAGMA synchronous = OFF" to avoid corruption in cookie service. r=mak
netwerk/cookie/nsCookieService.cpp
--- a/netwerk/cookie/nsCookieService.cpp
+++ b/netwerk/cookie/nsCookieService.cpp
@@ -1469,20 +1469,16 @@ nsCookieService::TryInitDB(bool aRecreat
 
         rv = CreateTable();
         NS_ENSURE_SUCCESS(rv, RESULT_RETRY);
       }
       break;
     }
   }
 
-  // make operations on the table asynchronous, for performance
-  mDefaultDBState->dbConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
-    "PRAGMA synchronous = OFF"));
-
   // Use write-ahead-logging for performance. We cap the autocheckpoint limit at
   // 16 pages (around 500KB).
   mDefaultDBState->dbConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
     MOZ_STORAGE_UNIQUIFY_QUERY_STR "PRAGMA journal_mode = WAL"));
   mDefaultDBState->dbConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
     "PRAGMA wal_autocheckpoint = 16"));
 
   // cache frequently used statements (for insertion, deletion, and updating)