Backed out changeset 9d6897b968f6 (bug 1551389) for crashtest failures on 1551389-1.html
authorNarcis Beleuzu <nbeleuzu@mozilla.com>
Wed, 15 May 2019 06:15:35 +0300
changeset 535779 b2bd4ee26110bb05115a37fa6affd756b048ee46
parent 535778 f907a581ad2bb61427e69dcc99e7bb72085f3fcd
child 535780 2c73bd0fae85c2e877932e9f98ffd28fe91538f1
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1551389
milestone68.0a1
backs out9d6897b968f6cd1b1cf525f19a45843907a157e9
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 9d6897b968f6 (bug 1551389) for crashtest failures on 1551389-1.html
layout/painting/crashtests/1551389-1.html
layout/painting/crashtests/crashtests.list
layout/painting/nsCSSRendering.cpp
deleted file mode 100644
--- a/layout/painting/crashtests/1551389-1.html
+++ /dev/null
@@ -1,6 +0,0 @@
-<style>
-dl::first-letter { float: right }
-* { -webkit-box-shadow: -moz-cellhighlighttext 0px 34px 1px }
-</style>
-<s dir="RTL">
-<dl style="break-inside: avoid">AA</iframe>
--- a/layout/painting/crashtests/crashtests.list
+++ b/layout/painting/crashtests/crashtests.list
@@ -13,10 +13,9 @@ load 1454105-1.html
 load 1455944-1.html
 load 1465305-1.html
 load 1468124-1.html
 load 1469472.html
 load 1477831-1.html
 load 1504033.html
 load 1514544-1.html
 load 1547420-1.html
-load 1551389-1.html
 
--- a/layout/painting/nsCSSRendering.cpp
+++ b/layout/painting/nsCSSRendering.cpp
@@ -383,18 +383,16 @@ struct InlineBackgroundData {
     if (nsBlockFrame* blockFrame = do_QueryFrame(mLineContainer)) {
       bool isValid1, isValid2;
       nsBlockInFlowLineIterator it1(blockFrame, aFrame1, &isValid1);
       nsBlockInFlowLineIterator it2(blockFrame, aFrame2, &isValid2);
       return isValid1 && isValid2 &&
              // Make sure aFrame1 and aFrame2 are in the same continuation of
              // blockFrame.
              it1.GetContainer() == it2.GetContainer() &&
-             // And both in the same line list
-             it1.GetLineList() == it2.GetLineList() &&
              // And on the same line in it
              it1.GetLine() == it2.GetLine();
     }
     if (nsRubyTextContainerFrame* rtcFrame = do_QueryFrame(mLineContainer)) {
       nsBlockFrame* block = nsLayoutUtils::FindNearestBlockAncestor(rtcFrame);
       // Ruby text container can only hold one line of text, so if they
       // are in the same continuation, they are in the same line. Since
       // ruby text containers are bidi isolate, they are never split for