Bug 680647 - undefined variables in some tests cause leaks; r=dao
authorTim Taubert <tim.taubert@gmx.de>
Sat, 20 Aug 2011 11:35:10 +0200
changeset 76931 b2617200c0dd468f98ab1f8ecdca59e9577431c9
parent 76855 6009974c1e1c42edaf2e39f298d499f759e1eea9
child 76932 d827ae445f330ec372fc79b334cab69213e5ff04
push id78
push userclegnitto@mozilla.com
push dateFri, 16 Dec 2011 17:32:24 +0000
treeherdermozilla-release@79d24e644fdd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs680647
milestone9.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 680647 - undefined variables in some tests cause leaks; r=dao
browser/base/content/test/tabview/browser_tabview_bug597248.js
browser/base/content/test/tabview/browser_tabview_bug642793.js
--- a/browser/base/content/test/tabview/browser_tabview_bug597248.js
+++ b/browser/base/content/test/tabview/browser_tabview_bug597248.js
@@ -17,17 +17,17 @@ function setupOne(win) {
   win.TabView.firstUseExperienced = true;
 
   win.gBrowser.addTab("http://mochi.test:8888/browser/browser/base/content/test/tabview/search1.html");
   win.gBrowser.addTab("http://mochi.test:8888/browser/browser/base/content/test/tabview/dummy_page.html");
 
   afterAllTabsLoaded(function () setupTwo(win), win);
 }
 
-let restoreWin;
+let restoredWin;
 
 function setupTwo(win) {
   let contentWindow = win.TabView.getContentWindow();
 
   let tabItems = contentWindow.TabItems.getItems();
   is(tabItems.length, 3, "There should be 3 tab items before closing");
 
   let numTabsToSave = tabItems.length;
--- a/browser/base/content/test/tabview/browser_tabview_bug642793.js
+++ b/browser/base/content/test/tabview/browser_tabview_bug642793.js
@@ -10,17 +10,17 @@ function loadTabs (win) {
   for (let i = 0; i < 4; i++)
     win.gBrowser.loadOneTab('about:blank', {inBackground: false});
   win.gBrowser.selectedTab = win.gBrowser.tabs[2];
 }
 
 function testTopOfStack(win) {
   registerCleanupFunction(function () { win.close(); });
   let cw = win.TabView.getContentWindow();
-  groupItem = cw.GroupItems.getActiveGroupItem();
+  let groupItem = cw.GroupItems.getActiveGroupItem();
   ok(!groupItem.isStacked(), 'groupItem is not stacked');
   groupItem.setSize(150, 150);
   groupItem.setUserSize();
   ok(groupItem.isStacked(), 'groupItem is now stacked');
   ok(groupItem.isTopOfStack(groupItem.getChild(2)),
     'the third tab is on top of stack');
   finish();
 }