Backed out changeset 55b7690ea8c5 (bug 1430729) for build bustage z:\build\build\src\obj-firefox\dist\include\mozilla/StaticPtr.h(107): error C2220 on a CLOSED TREE
authorAndreea Pavel <apavel@mozilla.com>
Tue, 16 Jan 2018 17:52:46 +0200
changeset 453747 b2588a5584c200b9dac8a6a0b0500f043cd335fe
parent 453746 b2c2c5e26ddc71fbd4390b5ba2661737c0dee653
child 453748 8a5167064bb7338d1ba9f98105d1dfee84f79b0f
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1430729
milestone59.0a1
backs out55b7690ea8c554e12d11ea015c90a0e2bd115389
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 55b7690ea8c5 (bug 1430729) for build bustage z:\build\build\src\obj-firefox\dist\include\mozilla/StaticPtr.h(107): error C2220 on a CLOSED TREE
xpcom/base/StaticPtr.h
--- a/xpcom/base/StaticPtr.h
+++ b/xpcom/base/StaticPtr.h
@@ -99,21 +99,17 @@ class MOZ_ONLY_USED_TO_AVOID_STATIC_CONS
 {
 public:
   // In debug builds, check that mRawPtr is initialized for us as we expect
   // by the compiler.  In non-debug builds, don't declare a constructor
   // so that the compiler can see that the constructor is trivial.
 #ifdef DEBUG
   StaticRefPtr()
   {
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wuninitialized"
-  // False positive with gcc. See bug 1430729
     MOZ_ASSERT(!mRawPtr);
-#pragma GCC diagnostic pop
   }
 #endif
 
   StaticRefPtr<T>& operator=(T* aRhs)
   {
     AssignWithAddref(aRhs);
     return *this;
   }