Bug 920734 - Part 2: Update tests to avoid using orientation as variable name. r=seth
authorWilliam Chen <wchen@mozilla.com>
Fri, 23 Oct 2015 21:37:35 -0700
changeset 304545 b227e94179e245747b321ec4bc106960afd731b4
parent 304544 f8c8a754583350b964cb251aed8ce6dc4eaaee7f
child 304546 d90b11b242df8dc9295341c56000b05c1dee6013
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersseth
bugs920734
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 920734 - Part 2: Update tests to avoid using orientation as variable name. r=seth
layout/reftests/image/image-orientation-explicit.html
layout/reftests/image/image-orientation-from-image.html
layout/reftests/image/image-orientation-generated-content-ref.html
layout/reftests/image/image-orientation-generated-content.html
layout/reftests/image/image-orientation-ref.html
layout/reftests/svg/as-image/image-orientation-no-viewbox-and-size.html
layout/reftests/svg/as-image/image-orientation-no-viewbox-no-size.html
layout/reftests/svg/as-image/image-orientation-ref.html
layout/reftests/svg/as-image/image-orientation-viewbox-and-size.html
layout/reftests/svg/as-image/image-orientation-viewbox-no-size.html
--- a/layout/reftests/image/image-orientation-explicit.html
+++ b/layout/reftests/image/image-orientation-explicit.html
@@ -14,19 +14,19 @@
   </style>
 </head>
 <body>
   <!-- This is deliberately an image with a non-neutral inherent orientation to
        ensure that the inherent orientation is irrelevant. -->
   <img src="image-exif-90-deg-flip.jpg">
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = orientation[0];
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = orientationInfo[0];
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Construct a style.
     var style = "img { image-orientation: "
               + angle + "deg"
               + (flip ? " flip" : "")
               + "; }\n";
 
     // Apply the style to the document.
--- a/layout/reftests/image/image-orientation-from-image.html
+++ b/layout/reftests/image/image-orientation-from-image.html
@@ -13,19 +13,19 @@
       padding: 50px;
     }
   </style>
 </head>
 <body>
   <img id="image">
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = orientation[0];
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = orientationInfo[0];
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Determine the final image file. 'none' is special-cased since its
     // filename doesn't quite follow the same pattern as the others.
     var imageFile;
     if (angle == "none") {
       imageFile = "image-exif-none.jpg";
     } else {
       var imageFile = "image-exif-"
--- a/layout/reftests/image/image-orientation-generated-content-ref.html
+++ b/layout/reftests/image/image-orientation-generated-content-ref.html
@@ -21,19 +21,19 @@
       <tr>
         <td id="ll"></td>
         <td id="lr"></td>
       </tr>
     </table>
   </div>
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = parseInt(orientation[0]);
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = parseInt(orientationInfo[0]);
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Each id corresponds to a color.
     var ids = ["ul", "ur", "lr", "ll"];
     var colors = [
       "rgb(0, 191, 0)",
       "rgb(0, 255, 1)",
       "rgb(254, 0, 122)",
       "rgb(191, 0, 93)",
--- a/layout/reftests/image/image-orientation-generated-content.html
+++ b/layout/reftests/image/image-orientation-generated-content.html
@@ -10,19 +10,19 @@
       content: url(image-exif-270-deg-flip.jpg);
     }
   </style>
 </head>
 <body>
   <p></p>
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = orientation[0];
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = orientationInfo[0];
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Construct a style. "from-image" is special-cased.
     var style;
     if (angle == "from-image") {
       style = "p { image-orientation: from-image; }\n";
     } else {
       style = "p { image-orientation: "
             + angle + "deg"
--- a/layout/reftests/image/image-orientation-ref.html
+++ b/layout/reftests/image/image-orientation-ref.html
@@ -26,19 +26,19 @@
       <tr>
         <td id="ll"></td>
         <td id="lr"></td>
       </tr>
     </table>
   </div>
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = parseInt(orientation[0]);
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = parseInt(orientationInfo[0]);
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Each id corresponds to a color.
     var ids = ["ul", "ur", "lr", "ll"];
     var colors = [
       "rgb(0, 191, 0)",
       "rgb(0, 255, 1)",
       "rgb(254, 0, 122)",
       "rgb(191, 0, 93)",
--- a/layout/reftests/svg/as-image/image-orientation-no-viewbox-and-size.html
+++ b/layout/reftests/svg/as-image/image-orientation-no-viewbox-and-size.html
@@ -7,19 +7,19 @@
       padding: 0px;
     }
   </style>
 </head>
 <body>
   <img src="image-orientation-no-viewbox-and-size.svg">
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = orientation[0];
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = orientationInfo[0];
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Construct a style. "from-image" is special-cased.
     var style;
     if (angle == "from-image") {
       style = "img { image-orientation: from-image; }\n";
     } else {
       style = "img { image-orientation: "
             + angle + "deg"
--- a/layout/reftests/svg/as-image/image-orientation-no-viewbox-no-size.html
+++ b/layout/reftests/svg/as-image/image-orientation-no-viewbox-no-size.html
@@ -11,19 +11,19 @@
       height: 200px;
     }
   </style>
 </head>
 <body>
   <img src="image-orientation-no-viewbox-no-size.svg">
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = orientation[0];
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = orientationInfo[0];
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Construct a style. "from-image" is special-cased.
     var orientationStyle;
     if (angle == "from-image") {
       orientationStyle = "image-orientation: from-image;";
     } else {
       orientationStyle = "image-orientation: "
                        + angle + "deg"
--- a/layout/reftests/svg/as-image/image-orientation-ref.html
+++ b/layout/reftests/svg/as-image/image-orientation-ref.html
@@ -21,19 +21,19 @@
       <tr>
         <td id="ll"></td>
         <td id="lr"></td>
       </tr>
     </table>
   </div>
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = parseInt(orientation[0]);
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = parseInt(orientationInfo[0]);
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Each id corresponds to a color.
     var ids = ["ul", "ur", "lr", "ll"];
     var colors = [
       "rgb(0, 191, 0)",
       "rgb(0, 255, 1)",
       "rgb(254, 0, 122)",
       "rgb(191, 0, 93)",
--- a/layout/reftests/svg/as-image/image-orientation-viewbox-and-size.html
+++ b/layout/reftests/svg/as-image/image-orientation-viewbox-and-size.html
@@ -7,19 +7,19 @@
       padding: 0px;
     }
   </style>
 </head>
 <body>
   <img src="image-orientation-viewbox-and-size.svg">
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = orientation[0];
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = orientationInfo[0];
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Construct a style. "from-image" is special-cased.
     var style;
     if (angle == "from-image") {
       style = "img { image-orientation: from-image; }\n";
     } else {
       style = "img { image-orientation: "
             + angle + "deg"
--- a/layout/reftests/svg/as-image/image-orientation-viewbox-no-size.html
+++ b/layout/reftests/svg/as-image/image-orientation-viewbox-no-size.html
@@ -7,19 +7,19 @@
       padding: 0px;
     }
   </style>
 </head>
 <body>
   <img src="image-orientation-viewbox-no-size.svg">
 
   <script>
-    var orientation = location.search.substring(1).split("&");
-    var angle = orientation[0];
-    var flip = orientation[1] == "flip" ? true : false;
+    var orientationInfo = location.search.substring(1).split("&");
+    var angle = orientationInfo[0];
+    var flip = orientationInfo[1] == "flip" ? true : false;
 
     // Construct a style. "from-image" is special-cased.
     var orientationStyle;
     if (angle == "from-image") {
       orientationStyle = "image-orientation: from-image;";
     } else {
       orientationStyle = "image-orientation: "
                        + angle + "deg"