Bug 1417052 - Use unique keyword in browser_ext_omnibox.js. r=aswan, a=test-only
authorRob Wu <rob@robwu.nl>
Wed, 01 Aug 2018 13:49:27 +0200
changeset 480814 afb2c70029f6a6401c67cf671072be88d95e1f27
parent 480813 fd81c0f6fb7f78e637235744e980d9498b58b77b
child 480815 1a80ac4f1ab7464dc0d2eeeeaba11ba37bf0aca0
push id1757
push userffxbld-merge
push dateFri, 24 Aug 2018 17:02:43 +0000
treeherdermozilla-release@736023aebdb1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaswan, test-only
bugs1417052, 1416103
milestone62.0
Bug 1417052 - Use unique keyword in browser_ext_omnibox.js. r=aswan, a=test-only Manually verified using the STR from https://bugzilla.mozilla.org/show_bug.cgi?id=1417052#c47 I am not re-enabling the test by default because the same test file is reported to have another intermittent (bug 1416103). MozReview-Commit-ID: 1xsyjMMby1H
browser/components/extensions/test/browser/browser-common.ini
browser/components/extensions/test/browser/browser_ext_omnibox.js
--- a/browser/components/extensions/test/browser/browser-common.ini
+++ b/browser/components/extensions/test/browser/browser-common.ini
@@ -101,17 +101,17 @@ skip-if = (verify && (os == 'linux' || o
 [browser_ext_incognito_views.js]
 [browser_ext_incognito_popup.js]
 [browser_ext_lastError.js]
 [browser_ext_menus.js]
 [browser_ext_menus_event_order.js]
 [browser_ext_menus_events.js]
 [browser_ext_menus_refresh.js]
 [browser_ext_omnibox.js]
-skip-if = (debug && (os == 'linux' || os == 'mac')) || (verify && (os == 'linux' || os == 'mac')) # Bug 1417052
+skip-if = (debug && (os == 'linux' || os == 'mac')) || (verify && (os == 'linux' || os == 'mac')) # Bug 1416103 (was bug 1417052)
 [browser_ext_openPanel.js]
 skip-if = (verify && !debug && (os == 'linux' || os == 'mac'))
 [browser_ext_optionsPage_browser_style.js]
 [browser_ext_optionsPage_modals.js]
 [browser_ext_optionsPage_privileges.js]
 [browser_ext_pageAction_context.js]
 skip-if = (verify && !debug && (os == 'linux'))
 [browser_ext_pageAction_contextMenu.js]
--- a/browser/components/extensions/test/browser/browser_ext_omnibox.js
+++ b/browser/components/extensions/test/browser/browser_ext_omnibox.js
@@ -1,14 +1,16 @@
 /* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* vim: set sts=2 sw=2 et tw=80: */
 "use strict";
 
 add_task(async function() {
-  let keyword = "test";
+  // This keyword needs to be unique to prevent history entries from unrelated
+  // tests from appearing in the suggestions list.
+  let keyword = "VeryUniqueKeywordThatDoesNeverMatchAnyTestUrl";
 
   let extension = ExtensionTestUtils.loadExtension({
     manifest: {
       "omnibox": {
         "keyword": keyword,
       },
     },