servo: Merge #19724 - Remove out of date FIXME comments from domimplementation (from hindenbug:19723-remove-fixme-comments); r=metajack
authorManoj <manoj.mk27@gmail.com>
Mon, 08 Jan 2018 19:28:49 -0600
changeset 452582 afaef5996b4cbf0fb1307fdbd37ffc7c8f1c5855
parent 452581 75edc4a8cbc37016ec33bcb513a0b6a7859879f1
child 452583 1b9c11ccbd5e73ff030f3ec1070674f05c08fed6
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmetajack
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
servo: Merge #19724 - Remove out of date FIXME comments from domimplementation (from hindenbug:19723-remove-fixme-comments); r=metajack <!-- Please describe your changes on the following line: --> This removes out of date FIXME comments from `domimplementation.rs` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #19723 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because this is a comment cleanup <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: aa199307c86051e13b17a5feb77722ddcdeed5ce
servo/components/script/dom/domimplementation.rs
--- a/servo/components/script/dom/domimplementation.rs
+++ b/servo/components/script/dom/domimplementation.rs
@@ -109,17 +109,17 @@ impl DOMImplementationMethods for DOMImp
 
             // Step 5.
             if let Some(ref elem) = maybe_elem {
                 doc_node.AppendChild(elem.upcast()).unwrap();
             }
         }
 
         // Step 6.
-        // FIXME: https://github.com/mozilla/servo/issues/1522
+        // The origin is already set
 
         // Step 7.
         Ok(doc)
     }
 
     // https://dom.spec.whatwg.org/#dom-domimplementation-createhtmldocument
     fn CreateHTMLDocument(&self, title: Option<DOMString>) -> DomRoot<Document> {
         let win = self.document.window();
@@ -178,17 +178,17 @@ impl DOMImplementationMethods for DOMImp
             }
 
             // Step 7.
             let doc_body = HTMLBodyElement::new(local_name!("body"), None, &doc);
             doc_html.AppendChild(doc_body.upcast()).unwrap();
         }
 
         // Step 8.
-        // FIXME: https://github.com/mozilla/servo/issues/1522
+        // The origin is already set
 
         // Step 9.
         doc
     }
 
     // https://dom.spec.whatwg.org/#dom-domimplementation-hasfeature
     fn HasFeature(&self) -> bool {
         true