Bug 1434888 - Update accessibility panel command key from Shift + F10 to Shift + F12. r=gl,flod, a=RyanVM, l10n=flod
authorYura Zenevich <yura.zenevich@gmail.com>
Wed, 12 Dec 2018 18:25:41 +0000
changeset 508988 aea4a31fb8bb43243c5e6eaa891958b1d803d95a
parent 508987 4a9792ce63e3011e473b9d33afdc686bdf47dec0
child 508989 8ed79de6c5baccc9271815a8a4dd19dcd82e2e29
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl, flod, RyanVM
bugs1434888
milestone65.0
Bug 1434888 - Update accessibility panel command key from Shift + F10 to Shift + F12. r=gl,flod, a=RyanVM, l10n=flod Differential Revision: https://phabricator.services.mozilla.com/D14261
devtools/client/definitions.js
devtools/startup/devtools-startup.js
devtools/startup/locales/en-US/key-shortcuts.properties
--- a/devtools/client/definitions.js
+++ b/devtools/client/definitions.js
@@ -408,17 +408,17 @@ Tools.accessibility = {
   modifiers: osString == "Darwin" ? "accel,alt" : "accel,shift",
   visibilityswitch: "devtools.accessibility.enabled",
   icon: "chrome://devtools/skin/images/tool-accessibility.svg",
   url: "chrome://devtools/content/accessibility/index.html",
   label: l10n("accessibility.label"),
   panelLabel: l10n("accessibility.panelLabel"),
   get tooltip() {
     return l10n("accessibility.tooltip3",
-                "Shift+" + functionkey(l10n("accessibility.commandkey")));
+                "Shift+" + functionkey(l10n("accessibilityF12.commandkey")));
   },
   inMenu: true,
 
   isTargetSupported(target) {
     return target.hasActor("accessibility");
   },
 
   build(iframeWindow, toolbox) {
--- a/devtools/startup/devtools-startup.js
+++ b/devtools/startup/devtools-startup.js
@@ -168,17 +168,17 @@ XPCOMUtils.defineLazyGetter(this, "KeySh
     {
       toolId: "dom",
       shortcut: KeyShortcutsBundle.GetStringFromName("dom.commandkey"),
       modifiers,
     },
     // Key for opening the Accessibility Panel
     {
       toolId: "accessibility",
-      shortcut: KeyShortcutsBundle.GetStringFromName("accessibility.commandkey"),
+      shortcut: KeyShortcutsBundle.GetStringFromName("accessibilityF12.commandkey"),
       modifiers: "shift",
     },
   ];
 
   if (isMac) {
     // Add the extra key command for macOS, so you can open the inspector with cmd+shift+C
     // like on Chrome DevTools.
     shortcuts.push({
--- a/devtools/startup/locales/en-US/key-shortcuts.properties
+++ b/devtools/startup/locales/en-US/key-shortcuts.properties
@@ -57,11 +57,11 @@ performance.commandkey=VK_F5
 # LOCALIZATION NOTE (storage.commandkey):
 # Key pressed to open a toolbox with the storage panel selected
 storage.commandkey=VK_F9
 
 # LOCALIZATION NOTE (dom.commandkey):
 # Key pressed to open a toolbox with the DOM panel selected
 dom.commandkey=W
 
-# LOCALIZATION NOTE (accessibility.commandkey):
+# LOCALIZATION NOTE (accessibilityF12.commandkey):
 # Key pressed to open a toolbox with the accessibility panel selected
-accessibility.commandkey=VK_F10
+accessibilityF12.commandkey=VK_F12