Bug 1506118 - Use chromeUtilsWindow to start the parser worker; r=Honza. a=jcristau
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Mon, 19 Nov 2018 16:33:22 +0000
changeset 501329 ae6c0e763e30e415e3b11ea34ed05e790839a36d
parent 501328 6b8aaf8b494127af8df6ca95796b2bcced6ed3b3
child 501330 fe71d237ab9576996b1216f8525c7399c145bf17
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza, jcristau
bugs1506118
milestone64.0
Bug 1506118 - Use chromeUtilsWindow to start the parser worker; r=Honza. a=jcristau As we were using the browserWindow to start the parser worker, this was causing an exception when evaluation from the browser toolbox. Using chromUtilsWindow fixes the issue. There is no tests yet as I'm not sure there's an easy way to test things in the browser toolbox. Differential Revision: https://phabricator.services.mozilla.com/D12101
devtools/client/webconsole/webconsole.js
--- a/devtools/client/webconsole/webconsole.js
+++ b/devtools/client/webconsole/webconsole.js
@@ -267,17 +267,17 @@ WebConsole.prototype = {
       return this._parserService;
     }
 
     this._parserService =
       require("devtools/client/debugger/new/src/workers/parser/index");
 
     this._parserService.start(
       "resource://devtools/client/debugger/new/dist/parser-worker.js",
-      this.browserWindow);
+      this.chromeUtilsWindow);
     return this._parserService;
   },
 
   /**
    * Retrieves the current selection from the Inspector, if such a selection
    * exists. This is used to pass the ID of the selected actor to the Web
    * Console server for the $0 helper.
    *