Bug 1466253. HTMLFieldSetElement::GetType should return void. r=qdot
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 01 Jun 2018 22:35:26 -0400
changeset 477689 ab9cf549cd35888c14fdc97155d50191baf4fca6
parent 477688 284705205651b1c4f0e730fb9ec71a72b8056b6a
child 477690 886337516a045b3188f3618b05ff720e44dfbae0
push id1757
push userffxbld-merge
push dateFri, 24 Aug 2018 17:02:43 +0000
treeherdermozilla-release@736023aebdb1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersqdot
bugs1466253
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1466253. HTMLFieldSetElement::GetType should return void. r=qdot
dom/html/HTMLFieldSetElement.cpp
dom/html/HTMLFieldSetElement.h
--- a/dom/html/HTMLFieldSetElement.cpp
+++ b/dom/html/HTMLFieldSetElement.cpp
@@ -93,21 +93,20 @@ HTMLFieldSetElement::AfterSetAttr(int32_
     }
   }
 
   return nsGenericHTMLFormElement::AfterSetAttr(aNameSpaceID, aName,
                                                 aValue, aOldValue,
                                                 aSubjectPrincipal, aNotify);
 }
 
-NS_IMETHODIMP
-HTMLFieldSetElement::GetType(nsAString& aType)
+void
+HTMLFieldSetElement::GetType(nsAString& aType) const
 {
   aType.AssignLiteral("fieldset");
-  return NS_OK;
 }
 
 /* static */
 bool
 HTMLFieldSetElement::MatchListedElements(Element* aElement, int32_t aNamespaceID,
                                          nsAtom* aAtom, void* aData)
 {
   nsCOMPtr<nsIFormControl> formControl = do_QueryInterface(aElement);
--- a/dom/html/HTMLFieldSetElement.h
+++ b/dom/html/HTMLFieldSetElement.h
@@ -78,17 +78,17 @@ public:
     GetHTMLAttr(nsGkAtoms::name, aValue);
   }
 
   void SetName(const nsAString& aValue, ErrorResult& aRv)
   {
     SetHTMLAttr(nsGkAtoms::name, aValue, aRv);
   }
 
-  NS_IMETHOD GetType(nsAString & aType);
+  void GetType(nsAString & aType) const;
 
   nsIHTMLCollection* Elements();
 
   // XPCOM WillValidate is OK for us
 
   // XPCOM Validity is OK for us
 
   // XPCOM GetValidationMessage is OK for us