Bug 1521984 - Can't drag downloaded PDF into about:privatebrowsing r=andreio
authorRicky Rosario <rickyrosario@gmail.com>
Wed, 23 Jan 2019 18:21:26 +0000
changeset 515149 a9e8206d6d350c321607aa597e61b136f89e7403
parent 515148 830639112fdb75f9fa8deb72d7844e9d7e642f4a
child 515150 5c6cdeb8648d342ef53db0e954189049cc640532
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersandreio
bugs1521984
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521984 - Can't drag downloaded PDF into about:privatebrowsing r=andreio MozReview-Commit-ID: FQvRmltnss7 Differential Revision: https://phabricator.services.mozilla.com/D17304
browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml
browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css
--- a/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml
+++ b/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml
@@ -71,17 +71,17 @@
     <div class="showPrivate showSearch container">
       <div class="logo-and-wordmark">
         <div class="logo" />
         <div class="wordmark" />
       </div>
       <div class="search-inner-wrapper">
         <button id="search-handoff-button" class="search-handoff-button" title="&aboutPrivateBrowsing.search.placeholder;" tabindex="-1">
           <div class="fake-textbox">&aboutPrivateBrowsing.search.placeholder;</div>
-          <div id="fake-editable" class="fake-editable" tabindex="-1" aria-hidden="true" contenteditable="" />
+          <input id="fake-editable" class="fake-editable" tabindex="-1" aria-hidden="true" />
           <div class="fake-caret" />
         </button>
         <input id="dummy-input" class="dummy-input" type="search" />
       </div>
       <div class="info">
         <h1>&aboutPrivateBrowsing.info.title;</h1>
         <p>
           &aboutPrivateBrowsing.info.description;
--- a/browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css
+++ b/browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css
@@ -136,17 +136,19 @@ a.button:hover:active {
 
 .search-inner-wrapper {
   display: flex;
   height: 48px;
   margin-bottom: 64px;
   padding: 0 22px;
 }
 
-.search-handoff-button {
+.search-handoff-button,
+.search-handoff-button:active,
+.search-handoff-button:enabled:hover:active  {
   background: #fff var(--newtab-search-icon) 12px center no-repeat;
   background-size: 24px;
   border: solid 1px rgba(249, 249, 250, 0.2);
   border-radius: 3px;
   box-shadow: 0 1px 4px 0 rgba(12, 12, 13, 0.2), 0 0 0 1px rgba(0, 0, 0, 0.15);
   cursor: text;
   font-size: 15px;
   margin: 0;
@@ -182,22 +184,24 @@ a.button:hover:active {
 }
 
 .fake-editable:focus {
   outline: none;
   caret-color: transparent;
 }
 
 .fake-editable {
-  color: transparent;
+  border: 0;
+  height: 100%;
+  left: 0;
+  opacity: 0;
+  padding: 0;
   position: absolute;
   top: 0;
-  left: 0;
-  right: 0;
-  bottom: 0;
+  width: 100%;
 }
 
 .fake-textbox {
   color: rgb(12, 12, 13);
   opacity: 0.54;
   text-align: start;
 }