Bug 1521105 - Align message-location and network request status text; r=nchevobbe
authorFlorens Verschelde <florens@fvsch.com>
Mon, 21 Jan 2019 07:24:49 +0000
changeset 514667 a8e0501505f47a64d8b26ab0be981a32cddd89ae
parent 514666 311d09aeb1ab0e1ee583123634a4b28975172969
child 514668 176554242eb31ffb066e48c84004eba1824293d5
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnchevobbe
bugs1521105
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521105 - Align message-location and network request status text; r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D16985
devtools/client/themes/webconsole.css
--- a/devtools/client/themes/webconsole.css
+++ b/devtools/client/themes/webconsole.css
@@ -65,16 +65,22 @@ a {
   padding-inline-start: 1px;
   padding-inline-end: 8px;
   border-inline-start: solid 3px transparent;
   font-size: var(--console-output-font-size);
   line-height: var(--console-output-line-height);
   position: relative;
 }
 
+@media (min-width: 1000px) {
+  .message {
+    padding-inline-end: 12px;
+  }
+}
+
 /*
  * By default, prevent any element in message to overflow.
  * This makes console reflows faster (See Bug 1487457).
  */
 .message * {
   overflow: hidden;
 }
 
@@ -255,49 +261,39 @@ a {
 .message-repeats[value="1"] {
   display: none;
 }
 
 .message-location {
   max-width: 40vw;
   flex-shrink: 0;
   color: var(--frame-link-source);
-  margin-inline-start: 5px;
-  margin-inline-end: 10px;
+  margin-inline-start: 1ch;
 }
 
-.stack-trace {
-  /* The markup contains extra whitespace to improve formatting of clipboard text.
-     Make sure this whitespace doesn't affect the HTML rendering */
-  white-space: normal;
+.message-location:empty {
+  display: none;
 }
 
-.message-location,
-.stack-trace .frame-link-source {
+.message-location .frame-link-source {
   /* Makes the file name truncated (and ellipsis shown) on the left side */
   direction: rtl;
+  display: block;
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
   text-align: end;
 }
 
-.stack-trace .frame-link-source-inner,
 .message-location .frame-link-source-inner {
   /* Enforce LTR direction for the file name - fixes bug 1290056 */
   direction: ltr;
   unicode-bidi: embed;
 }
 
-.stack-trace .frame-link-function-display-name {
-  white-space: nowrap;
-  overflow: hidden;
-  text-overflow: ellipsis;
-}
-
 .message-flex-body {
   display: flex;
 }
 
 .message-body {
   white-space: pre-wrap;
   word-wrap: break-word;
 }
@@ -337,28 +333,28 @@ a {
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
   cursor: default;
 }
 
 .message.network .status {
   flex: none;
-  margin-inline-start: 6px;
+  margin-inline-start: 1ch;
   cursor: default;
 }
 
 .message.network.mixed-content .url {
   color: var(--theme-highlight-red);
   cursor: default;
 }
 
 .message .learn-more-link {
   color: var(--theme-highlight-blue);
-  margin: 0 6px;
+  margin: 0 1ch;
 }
 
 .message.network .xhr {
   background-color: var(--theme-body-color-alt);
   color: var(--theme-body-background);
   border-radius: 3px;
   font-weight: bold;
   font-size: 10px;
@@ -692,17 +688,17 @@ a.learn-more-link.webconsole-learn-more-
 /* Prefix text that can be set by ConsoleAPI option */
 .webconsole-output-wrapper .console-message-prefix {
   color: var(--theme-comment);
 }
 
 /* Network Messages */
 
 .webconsole-output-wrapper .message.network .method {
-  margin-inline-end: 5px;
+  margin-inline-end: 1ch;
 }
 
 .webconsole-output-wrapper .message.network .xhr {
   background-color: var(--theme-comment);
   color: white;
   border-radius: 2px;
   font-weight: normal;
   line-height: inherit;