Bug 1558763 - [marionette] Disable "browser.tabs.remote.separatePrivilegedContentProcess" by default. r=maja_zf a=test-only
authorHenrik Skupin <mail@hskupin.info>
Wed, 12 Jun 2019 13:45:32 +0000
changeset 536915 a8b7e99e3f6cf77e4e95112833841f708677dad1
parent 536914 fa07e1e87d3b98a8187590f3840954f8b90cdf0e
child 536916 b4a6eae77dcef08cbfafb77adb86360f01347006
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmaja_zf, test-only
bugs1558763, 1557457
milestone68.0
Bug 1558763 - [marionette] Disable "browser.tabs.remote.separatePrivilegedContentProcess" by default. r=maja_zf a=test-only Due to bug 1557457 it can happen that loading a web page with eg. a HTTP auth prompt, no modal dialog will be shown by Firefox. As such disable this preference for now globally, until all the issues with privileged content processes have been solved. Differential Revision: https://phabricator.services.mozilla.com/D34710
testing/marionette/client/marionette_driver/geckoinstance.py
testing/marionette/components/marionette.js
--- a/testing/marionette/client/marionette_driver/geckoinstance.py
+++ b/testing/marionette/client/marionette_driver/geckoinstance.py
@@ -552,16 +552,19 @@ class DesktopInstance(GeckoInstance):
         # Needed for branded builds to prevent opening a second tab on startup
         "browser.startup.homepage_override.mstone": "ignore",
         # Start with a blank page by default
         "browser.startup.page": 0,
 
         # Disable browser animations
         "toolkit.cosmeticAnimations.enabled": False,
 
+        # Bug 1557457: Disable because modal dialogs might not appear in Firefox
+        "browser.tabs.remote.separatePrivilegedContentProcess": False,
+
         # Don't unload tabs when available memory is running low
         "browser.tabs.unloadOnLowMemory": False,
 
         # Do not warn when closing all open tabs
         "browser.tabs.warnOnClose": False,
         # Do not warn when closing all other open tabs
         "browser.tabs.warnOnCloseOtherTabs": False,
         # Do not warn when multiple tabs will be opened
--- a/testing/marionette/components/marionette.js
+++ b/testing/marionette/components/marionette.js
@@ -126,16 +126,19 @@ const RECOMMENDED_PREFS = new Map([
   // Do not close the window when the last tab gets closed
   ["browser.tabs.closeWindowWithLastTab", false],
 
   // Do not allow background tabs to be zombified on Android, otherwise for
   // tests that open additional tabs, the test harness tab itself might get
   // unloaded
   ["browser.tabs.disableBackgroundZombification", false],
 
+  // Bug 1557457: Disable because modal dialogs might not appear in Firefox
+  ["browser.tabs.remote.separatePrivilegedContentProcess", false],
+
   // Don't unload tabs when available memory is running low
   ["browser.tabs.unloadOnLowMemory", false],
 
   // Do not warn when closing all open tabs
   ["browser.tabs.warnOnClose", false],
 
   // Do not warn when closing all other open tabs
   ["browser.tabs.warnOnCloseOtherTabs", false],