Bug 1358185 - Force FixedPosition display items to be active. r=mstange, a=gchang
authorJamie Nicol <jnicol@mozilla.com>
Wed, 03 May 2017 16:49:43 +0100
changeset 396206 a849ff78181fa13a8160d24452fd06a4f82a4b00
parent 396205 6d31880f7b72213e9663f1208fec400e7e5a0b8d
child 396207 c955a7aedcc2bdf4de87aa5aba713e1209737dd3
push id1468
push userasasaki@mozilla.com
push dateMon, 05 Jun 2017 19:31:07 +0000
treeherdermozilla-release@0641fc6ee9d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange, gchang
bugs1358185
milestone54.0
Bug 1358185 - Force FixedPosition display items to be active. r=mstange, a=gchang Fixed backgrounds were not being clipped correctly when rendered using inactive layers. MozReview-Commit-ID: 3v8tajr3MoB
layout/painting/nsDisplayList.h
--- a/layout/painting/nsDisplayList.h
+++ b/layout/painting/nsDisplayList.h
@@ -4089,17 +4089,17 @@ public:
   virtual already_AddRefed<Layer> BuildLayer(nsDisplayListBuilder* aBuilder,
                                              LayerManager* aManager,
                                              const ContainerLayerParameters& aContainerParameters) override;
   NS_DISPLAY_DECL_NAME("FixedPosition", TYPE_FIXED_POSITION)
   virtual LayerState GetLayerState(nsDisplayListBuilder* aBuilder,
                                    LayerManager* aManager,
                                    const ContainerLayerParameters& aParameters) override
   {
-    return mozilla::LAYER_ACTIVE;
+    return mozilla::LAYER_ACTIVE_FORCE;
   }
   virtual bool TryMerge(nsDisplayItem* aItem) override;
 
   virtual bool ShouldFixToViewport(nsDisplayListBuilder* aBuilder) override { return mIsFixedBackground; }
 
   virtual uint32_t GetPerFrameKey() override { return (mIndex << nsDisplayItem::TYPE_BITS) | nsDisplayItem::GetPerFrameKey(); }
 
   AnimatedGeometryRoot* AnimatedGeometryRootForScrollMetadata() const override {