Bug 1567714 - Fix .urlbar-display text color on themes. r=dao a=RyanVM
authorTim Nguyen <ntim.bugs@gmail.com>
Wed, 21 Aug 2019 08:15:30 +0000
changeset 545245 a7f4215a7edaab8ab3341177feae92b0b1393b08
parent 545244 f272644e18fa76a7c5d1feab52f1d9322a9e4794
child 545246 14b258057e3438522d89cae57b399d89af4d8d01
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao, RyanVM
bugs1567714
milestone69.0
Bug 1567714 - Fix .urlbar-display text color on themes. r=dao a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D42744
browser/themes/linux/browser.css
browser/themes/osx/browser.css
browser/themes/shared/urlbar-searchbar.inc.css
browser/themes/windows/browser.css
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -243,20 +243,17 @@ menuitem.bookmark-item {
 }
 
 #urlbar-display-box {
   margin-top: -1px;
   margin-bottom: -1px;
 }
 
 .urlbar-display {
-  margin-top: 0;
-  margin-bottom: 0;
   margin-inline-start: 0;
-  color: GrayText;
 }
 
 %include ../shared/urlbarSearchSuggestionsNotification.inc.css
 
 #search-container {
   min-width: calc(54px + 11ch);
 }
 
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -308,22 +308,16 @@ html|input.urlbar-input {
 #search-container {
   min-width: calc(54px + 11ch);
 }
 
 #wrapper-urlbar-container[place="palette"] {
   max-width: 20em;
 }
 
-.urlbar-display {
-  margin-top: 0;
-  margin-bottom: 0;
-  color: GrayText;
-}
-
 #pageAction-urlbar-shareURL,
 #pageAction-panel-shareURL {
   list-style-image: url("chrome://browser/skin/share.svg");
 }
 
 %include ../shared/urlbarSearchSuggestionsNotification.inc.css
 
 /* ----- AUTOCOMPLETE ----- */
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -336,17 +336,30 @@
 
 .urlbar-icon:-moz-focusring,
 .urlbar-icon-wrapper:-moz-focusring {
   outline: var(--toolbarbutton-focus-outline);
   outline-offset: -2px;
   -moz-outline-radius: var(--toolbarbutton-border-radius);
 }
 
-.urlbar-go-button,
+.urlbar-display {
+  margin-top: 0;
+  margin-bottom: 0;
+}
+
+.urlbar-display:not(:-moz-lwtheme) {
+  color: GrayText;
+}
+
+.urlbar-display:-moz-lwtheme {
+  opacity: 0.5;
+}
+
+#urlbar-go-button,
 .search-go-button {
   list-style-image: url("chrome://browser/skin/forward.svg");
 }
 
 .urlbar-go-button:-moz-locale-dir(rtl),
 .search-go-button:-moz-locale-dir(rtl) {
   transform: scaleX(-1);
 }
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -597,20 +597,17 @@ menuitem.bookmark-item {
   background-color: var(--arrowpanel-dimmed);
 }
 
 #urlbar-search-settings:hover:active {
   background-color: var(--arrowpanel-dimmed-further);
 }
 
 .urlbar-display {
-  margin-top: 0;
-  margin-bottom: 0;
   margin-inline-start: 0;
-  color: GrayText;
 }
 
 #pageAction-urlbar-shareURL,
 #pageAction-panel-shareURL {
   list-style-image: url("chrome://browser/skin/share.svg");
 }
 
 %include ../shared/urlbarSearchSuggestionsNotification.inc.css