Bug 1351335 - Don't close software update dialog before restart. r=ato, a=test-only
authorHenrik Skupin <mail@hskupin.info>
Wed, 29 Mar 2017 10:42:55 +0200
changeset 379399 a7cd0fc138fbf8f91f5ba95bcb76972639f879b5
parent 379398 0c8604d19f4a6908cab007b06241be907a87eeba
child 379400 c2a69c08a6691fe3965ae6eaf7aec49b5dda9f3f
push id1419
push userjlund@mozilla.com
push dateMon, 10 Apr 2017 20:44:07 +0000
treeherdermozilla-release@5e6801b73ef6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato, test-only
bugs1351335
milestone53.0
Bug 1351335 - Don't close software update dialog before restart. r=ato, a=test-only There is no need to close this dialog given that a restart happens anyway. But doing that as right now, and trying to invoke execute_script() on it, will end up with a unlocatable window. MozReview-Commit-ID: 53yBLYsWX4o
testing/firefox-ui/harness/firefox_ui_harness/testcases.py
--- a/testing/firefox-ui/harness/firefox_ui_harness/testcases.py
+++ b/testing/firefox-ui/harness/firefox_ui_harness/testcases.py
@@ -317,17 +317,16 @@ class UpdateTestCase(PuppeteerMixin, Mar
 
         else:
             try:
                 self.assertEqual(dialog.wizard.selected_panel,
                                  dialog.wizard.error_patching)
 
                 # Start downloading the fallback update
                 self.download_update(dialog)
-                dialog.close()
 
             finally:
                 self.updates[self.current_update_index]['patch'] = self.patch_info
 
         # Restart Firefox to apply the update
         self.restart()
 
     def read_update_log(self):