Bug 1482389, remove tree box object special case in Codegen.py, r=bz
authorNeil Deakin <neil@mozilla.com>
Mon, 14 Jan 2019 20:59:34 -0500
changeset 513842 a4b83cd280350877dd748848d41e4671f3970a3b
parent 513841 b83fde2c2c25683ed652cdf6ddaabb3e459f3a7b
child 513843 2830bd5ae375b5df6967d2cbb17264539161da5b
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1482389
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1482389, remove tree box object special case in Codegen.py, r=bz
dom/bindings/Codegen.py
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -7399,21 +7399,18 @@ class CGCallGenerator(CGThing):
 
         # Build up our actual call
         self.cgRoot = CGList([])
 
         call = CGGeneric(nativeMethodName)
         if not static:
             call = CGWrapper(call, pre="%s->" % object)
         call = CGList([call, CGWrapper(args, pre="(", post=")")])
-        if ((returnType is None or returnType.isVoid() or
-             resultOutParam is not None) and
-            # This check for TreeBoxObject is here due to bug 1434641.  Once
-            # nsITreeBoxObject is gone, it can go away.
-            descriptor.name != "TreeBoxObject"):
+        if (returnType is None or returnType.isVoid() or
+            resultOutParam is not None):
             assert resultConversion is None
             call = CGList([
                 CGWrapper(
                     call,
                     pre=("// NOTE: This assert does NOT call the function.\n"
                          "static_assert(mozilla::IsVoid<decltype("),
                     post=')>::value, "Should be returning void here");'),
                 call], "\n")