Bug 1576844 - Add a tabDetached even in content-process spec. r=yulia.
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Tue, 27 Aug 2019 16:36:55 +0000
changeset 554017 a49a4f5227143c4aacf4ff69e7e8ae31946b5993
parent 554016 3f59edce5ead7025c7311fcbf9245787f7cb3579
child 554018 68447f87ca05e2d5dc29258b594aa5cf028de829
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersyulia
bugs1576844
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1576844 - Add a tabDetached even in content-process spec. r=yulia. This event is sent from the content-process-connector in the server, and not having it declared in the spec was causing unknown packets error messages. Differential Revision: https://phabricator.services.mozilla.com/D43587
devtools/shared/specs/targets/content-process.js
--- a/devtools/shared/specs/targets/content-process.js
+++ b/devtools/shared/specs/targets/content-process.js
@@ -1,15 +1,16 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 "use strict";
 
 const {
   types,
+  Option,
   RetVal,
   generateActorSpec,
 } = require("devtools/shared/protocol");
 
 types.addDictType("contentProcessTarget.workers", {
   error: "nullable:string",
   workers: "nullable:array:workerTarget",
 });
@@ -32,12 +33,16 @@ const contentProcessTargetSpec = generat
     // The thread actor is no longer emitting newSource event in the name of the target
     // actor (bug 1269919), but as we may still connect to older servers which still do,
     // we have to keep it being mentioned here. Otherwise the event is considered as a
     // response to a request and confuses the packet ordering.
     // We can remove that once FF66 is no longer supported.
     newSource: {
       type: "newSource",
     },
+    tabDetached: {
+      type: "tabDetached",
+      from: Option(0, "string"),
+    },
   },
 });
 
 exports.contentProcessTargetSpec = contentProcessTargetSpec;