Bug 1551490 - Update test expectation of browser_reinstall.js for 68. r=rpl, a=test-only
authorRob Wu <rob@robwu.nl>
Tue, 11 Jun 2019 21:18:38 +0000
changeset 536907 a2fc7a9510bdc4d1f18cae3f1938a79c9a8e0c67
parent 536906 466fe0fc7db3f5d4d740ff388c15aa7dc9eff14b
child 536908 8620e798567200858369c6508014d18d80793e3c
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrpl, test-only
bugs1551490, 1552714
milestone68.0
Bug 1551490 - Update test expectation of browser_reinstall.js for 68. r=rpl, a=test-only The output of a non-existing attribute changed in bug 1552714. In 69, the expectation is `{id: null, args: null}`. In 68 and before, the expectation is `{id: ""}`. Differential Revision: https://phabricator.services.mozilla.com/D34615
toolkit/mozapps/extensions/test/browser/browser_reinstall.js
--- a/toolkit/mozapps/extensions/test/browser/browser_reinstall.js
+++ b/toolkit/mozapps/extensions/test/browser/browser_reinstall.js
@@ -89,19 +89,18 @@ async function check_addon(aAddon, aVers
   let { version } = await get_tooltip_info(item, gManagerWindow);
   is(version, aVersion, "Version should be correct");
 
   if (gManagerWindow.useHtmlViews) {
     const l10nAttrs = item.ownerDocument.l10n.getAttributes(item.querySelector(".addon-name"));
     if (aAddon.userDisabled) {
       Assert.deepEqual(l10nAttrs, {id: "addon-name-disabled", args: {name: aAddon.name}},
                        "localized addon name is marked as disabled");
-     } else {
-       Assert.deepEqual(l10nAttrs, {id: null, args: null},
-                        "localized addon name is not marked as disabled");
+    } else {
+      ok(!l10nAttrs.id, "localized addon name is not marked as disabled");
     }
 
     return;
   }
 
   if (aAddon.userDisabled) {
     is_element_visible(get_class_node(item, "disabled-postfix"), "Disabled postfix should be hidden");
   } else {