Bug 1315716 - Use selectableItemBackground for material ripple on ActivityStream cards r=sebastian
authorAndrzej Hunt <ahunt@mozilla.com>
Tue, 08 Nov 2016 08:00:10 -0500
changeset 367099 a2ea3980ed5df53c242ba569fc89282281744329
parent 367098 c23a8d5e4088962b5c70359257bdc85c3aa189ec
child 367100 2168cbd4b15410c24f6947e9218385dd8a0ab3dd
push id1369
push userjlorenzo@mozilla.com
push dateMon, 27 Feb 2017 14:59:41 +0000
treeherdermozilla-release@d75a1dba431f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1315716
milestone52.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1315716 - Use selectableItemBackground for material ripple on ActivityStream cards r=sebastian MozReview-Commit-ID: KQvNTB5RVbQ
mobile/android/base/resources/layout/activity_stream_card_history_item.xml
mobile/android/base/resources/layout/activity_stream_topsites_card.xml
--- a/mobile/android/base/resources/layout/activity_stream_card_history_item.xml
+++ b/mobile/android/base/resources/layout/activity_stream_card_history_item.xml
@@ -14,17 +14,18 @@
     android:layout_marginStart="@dimen/activity_stream_base_margin"
     android:layout_marginTop="0dp"
     android:orientation="vertical">
 
     <RelativeLayout
         android:layout_width="fill_parent"
         android:layout_height="match_parent"
         android:orientation="horizontal"
-        android:padding="10dp">
+        android:padding="10dp"
+        android:background="?android:attr/selectableItemBackground">
 
         <org.mozilla.gecko.widget.FaviconView
             android:id="@+id/icon"
             android:layout_width="@dimen/favicon_bg"
             android:layout_height="@dimen/favicon_bg"
             android:layout_gravity="center"
             gecko:enableRoundCorners="false"
             tools:background="@drawable/favicon_globe" />
--- a/mobile/android/base/resources/layout/activity_stream_topsites_card.xml
+++ b/mobile/android/base/resources/layout/activity_stream_topsites_card.xml
@@ -3,17 +3,18 @@
     xmlns:gecko="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="wrap_content"
     android:layout_height="wrap_content">
 
     <RelativeLayout
         android:id="@+id/content"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content">
+        android:layout_height="wrap_content"
+        android:background="?android:attr/selectableItemBackground">
 
         <org.mozilla.gecko.widget.FaviconView
             android:id="@+id/favicon"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_above="@+id/title"
             android:layout_alignParentTop="true"
             android:layout_centerHorizontal="true"