Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. r=stransky
authorDão Gottwald <dao@mozilla.com>
Tue, 24 Apr 2018 17:58:53 +0200
changeset 471597 a2d670a8074e2c93beb71fd90a0cd829d041bbb9
parent 471561 e786f1edbbefa7dadbb2e0ba5b7939f2bf4f1273
child 471598 7b8e832071f1c1b64d05dd597d692f4d4eb0866e
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersstransky
bugs1456522
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1456522 - Stop making the tabs toolbar transparent when there's no title bar behind it, i.e. in fullscreen mode. r=stransky MozReview-Commit-ID: DuKPGXKqtnD
browser/themes/linux/browser.css
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -645,22 +645,22 @@ notification[value="translation"] menuli
 @media (-moz-gtk-csd-available) {
   :root[tabsintitlebar] > #titlebar:-moz-lwtheme {
     visibility: hidden;
   }
   :root[tabsintitlebar] #titlebar-content:-moz-lwtheme {
     visibility: visible;
   }
 
+  :root[tabsintitlebar] > #titlebar {
+    -moz-appearance: -moz-window-titlebar-maximized;
+  }
   :root[tabsintitlebar][sizemode="normal"] > #titlebar {
     -moz-appearance: -moz-window-titlebar;
   }
-  :root[tabsintitlebar][sizemode="maximized"] > #titlebar {
-    -moz-appearance: -moz-window-titlebar-maximized;
-  }
 
   /* Add extra space to titlebar for dragging */
   :root[sizemode="normal"][chromehidden~="menubar"] #TabsToolbar,
   :root[sizemode="normal"] #toolbar-menubar[autohide="true"][inactive] + #TabsToolbar {
     padding-top: var(--space-above-tabbar);
   }
 
   /* Private browsing and accessibility indicators */
@@ -669,17 +669,18 @@ notification[value="translation"] menuli
   :root[sizemode="normal"] #toolbar-menubar[autohide="true"][inactive] + #TabsToolbar > .private-browsing-indicator,
   :root[sizemode="normal"] #toolbar-menubar[autohide="true"][inactive] + #TabsToolbar > .accessibility-indicator {
     padding-top: calc(-1 * var(--space-above-tabbar));
   }
 
   /* Make #TabsToolbar transparent as we style underlying #titlebar with
    * -moz-window-titlebar (Gtk+ theme).
    */
-  :root[tabsintitlebar] #TabsToolbar,
+  :root[tabsintitlebar][sizemode="normal"]:not([inFullscreen]) #TabsToolbar,
+  :root[tabsintitlebar][sizemode="maximized"] #TabsToolbar,
   :root[tabsintitlebar] #toolbar-menubar {
     -moz-appearance: none;
   }
 
   /* The button box must appear on top of the navigator-toolbox in order for
    * click and hover mouse events to work properly for the button in the restored
    * window state. Otherwise, elements in the navigator-toolbox, like the menubar,
    * can swallow those events.