Bug 1560134: Use built-in/succeed worker type for dummy jobs; r=dustin
☠☠ backed out by da33e6261a81 ☠ ☠
authorTom Prince <mozilla@hocat.ca>
Fri, 28 Jun 2019 20:12:52 +0000
changeset 543803 a14daf0a53cf85cee27285acf396aca6fb03bb99
parent 543802 35f409d120b18c55e334c7205372a47b4eef8342
child 543804 6d492faea9ecc22e09ea2758d9fc0bee830ccc16
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdustin
bugs1560134
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1560134: Use built-in/succeed worker type for dummy jobs; r=dustin Differential Revision: https://phabricator.services.mozilla.com/D36379
taskcluster/ci/config.yml
taskcluster/ci/post-balrog-dummy/kind.yml
taskcluster/ci/post-beetmover-checksums-dummy/kind.yml
taskcluster/ci/post-beetmover-dummy/kind.yml
taskcluster/ci/post-langpack-dummy/kind.yml
taskcluster/ci/release-notify-promote/kind.yml
taskcluster/ci/release-notify-push/kind.yml
taskcluster/ci/release-notify-ship/kind.yml
taskcluster/ci/release-partner-repack-chunking-dummy/kind.yml
taskcluster/ci/release-secondary-notify-ship/kind.yml
taskcluster/taskgraph/transforms/task.py
--- a/taskcluster/ci/config.yml
+++ b/taskcluster/ci/config.yml
@@ -380,16 +380,21 @@ workers:
             implementation: generic-worker
             os: windows
             worker-type: 'gecko-{alias}'
         t-win10-64(-hw|-ref-hw|-ux):
             provisioner: releng-hardware
             implementation: generic-worker
             os: windows
             worker-type: 'gecko-{alias}'
+        succeed:
+            provisioner: built-in
+            implementation: succeed
+            os: none
+            worker-type: succeed
         t-win7-32(|-gpu):
             provisioner: aws-provisioner-v1
             implementation: generic-worker
             os: windows
             worker-type: 'gecko-{alias}'
         t-win64-aarch64-laptop:
             provisioner: bitbar
             implementation: generic-worker
--- a/taskcluster/ci/post-balrog-dummy/kind.yml
+++ b/taskcluster/ci/post-balrog-dummy/kind.yml
@@ -11,18 +11,11 @@ transforms:
 
 kind-dependencies:
     - balrog
 
 job-template:
     description: Dummy task to deal with max_dependencies
     run-on-projects: []
     shipping-phase: promote
-    worker-type: b-linux
+    worker-type: succeed
     worker:
-        implementation: docker-worker
-        os: linux
-        docker-image: "ubuntu:16.10"
-        max-run-time: 600
-        command:
-            - /bin/bash
-            - -c
-            - echo "Dummy task"
+        implementation: succeed
--- a/taskcluster/ci/post-beetmover-checksums-dummy/kind.yml
+++ b/taskcluster/ci/post-beetmover-checksums-dummy/kind.yml
@@ -16,50 +16,29 @@ kind-dependencies:
 
 jobs:
     firefox-promote:
         name: post-beetmover-checksums-dummy
         description: Dummy task to deal with max_dependencies
         run-on-projects: []
         shipping-phase: promote
         shipping-product: firefox
-        worker-type: b-linux
+        worker-type: succeed
         worker:
-            implementation: docker-worker
-            os: linux
-            docker-image: "ubuntu:16.10"
-            max-run-time: 600
-            command:
-                - /bin/bash
-                - -c
-                - echo "Dummy task"
+            implementation: succeed
     devedition-promote:
         name: post-beetmover-checksums-dummy
         description: Dummy task to deal with max_dependencies
         run-on-projects: []
         shipping-phase: promote
         shipping-product: devedition
-        worker-type: b-linux
+        worker-type: succeed
         worker:
-            implementation: docker-worker
-            os: linux
-            docker-image: "ubuntu:16.10"
-            max-run-time: 600
-            command:
-                - /bin/bash
-                - -c
-                - echo "Dummy task"
+            implementation: succeed
     fennec-promote:
         name: post-beetmover-checksums-dummy
         description: Dummy task to deal with max_dependencies
         run-on-projects: []
         shipping-phase: promote
         shipping-product: fennec
-        worker-type: b-linux
+        worker-type: succeed
         worker:
-            implementation: docker-worker
-            os: linux
-            docker-image: "ubuntu:16.10"
-            max-run-time: 600
-            command:
-                - /bin/bash
-                - -c
-                - echo "Dummy task"
+            implementation: succeed
--- a/taskcluster/ci/post-beetmover-dummy/kind.yml
+++ b/taskcluster/ci/post-beetmover-dummy/kind.yml
@@ -15,18 +15,11 @@ kind-dependencies:
     # Fennec doesn't have beetmover-{checksums,repackage}, so
     # also depend on vanilla beetmover.
     - beetmover
 
 job-template:
     description: Dummy task to deal with max_dependencies
     run-on-projects: []
     shipping-phase: promote
-    worker-type: b-linux
+    worker-type: succeed
     worker:
-        implementation: docker-worker
-        os: linux
-        docker-image: "ubuntu:16.10"
-        max-run-time: 600
-        command:
-            - /bin/bash
-            - -c
-            - echo "Dummy task"
+        implementation: succeed
--- a/taskcluster/ci/post-langpack-dummy/kind.yml
+++ b/taskcluster/ci/post-langpack-dummy/kind.yml
@@ -13,35 +13,21 @@ kind-dependencies:
 
 jobs:
     firefox-promote:
         name: post-langpack-dummy
         description: Dummy task to deal with max_dependencies
         run-on-projects: []
         shipping-phase: promote
         shipping-product: firefox
-        worker-type: b-linux
+        worker-type: succeed
         worker:
-            implementation: docker-worker
-            os: linux
-            docker-image: "ubuntu:16.10"
-            max-run-time: 600
-            command:
-                - /bin/bash
-                - -c
-                - echo "Dummy task"
+            implementation: succeed
 
     devedition-promote:
         name: post-langpack-dummy
         description: Dummy task to deal with max_dependencies
         run-on-projects: []
         shipping-phase: promote
         shipping-product: devedition
-        worker-type: b-linux
+        worker-type: succeed
         worker:
-            implementation: docker-worker
-            os: linux
-            docker-image: "ubuntu:16.10"
-            max-run-time: 600
-            command:
-                - /bin/bash
-                - -c
-                - echo "Dummy task"
+            implementation: succeed
--- a/taskcluster/ci/release-notify-promote/kind.yml
+++ b/taskcluster/ci/release-notify-promote/kind.yml
@@ -14,26 +14,19 @@ kind-dependencies:
     - release-generate-checksums-beetmover
     - release-bouncer-sub
 
 job-defaults:
     name: notify-release-drivers-promote
     description: Sends email to release-drivers telling release was promoted.
     run-on-projects: []
     shipping-phase: promote
-    worker-type: b-linux
+    worker-type: succeed
     worker:
-        implementation: docker-worker
-        os: linux
-        docker-image: "ubuntu:16.10"
-        max-run-time: 600
-        command:
-            - /bin/bash
-            - -c
-            - echo "Dummy task"
+        implementation: succeed
     notifications:
         subject: "{task[shipping-product]} {release_config[version]} build{release_config[build_number]}/{config[params][project]} is in the candidates directory"
         message: "{task[shipping-product]} {release_config[version]} build{release_config[build_number]}/{config[params][project]} is in the candidates directory"
         emails:
             by-project:
                 mozilla-(beta|release|esr.*): ["release-signoff@mozilla.org"]
                 try: ["{config[params][owner]}"]
                 default: []
--- a/taskcluster/ci/release-notify-push/kind.yml
+++ b/taskcluster/ci/release-notify-push/kind.yml
@@ -12,26 +12,19 @@ transforms:
 kind-dependencies:
     - release-beetmover-push-to-release
 
 job-defaults:
     name: notify-release-drivers-push
     description: Sends email to release-drivers telling release was pushed.
     run-on-projects: []
     shipping-phase: push
-    worker-type: b-linux
+    worker-type: succeed
     worker:
-        implementation: docker-worker
-        os: linux
-        docker-image: "ubuntu:16.10"
-        max-run-time: 600
-        command:
-            - /bin/bash
-            - -c
-            - echo "Dummy task"
+        implementation: succeed
     notifications:
         subject: "{task[shipping-product]} {release_config[version]} build{release_config[build_number]}/{config[params][project]} has been pushed to cdntest"
         message: "{task[shipping-product]} {release_config[version]} build{release_config[build_number]}/{config[params][project]} has been pushed to cdntest"
         emails:
             by-project:
                 mozilla-(beta|release|esr.*): ["release-signoff@mozilla.org"]
                 try: ["{config[params][owner]}"]
                 default: []
--- a/taskcluster/ci/release-notify-ship/kind.yml
+++ b/taskcluster/ci/release-notify-ship/kind.yml
@@ -16,26 +16,19 @@ kind-dependencies:
     - release-version-bump
     - release-mark-as-shipped
 
 job-defaults:
     name: notify-release-drivers-ship
     description: Sends email to release-drivers telling release was shipped.
     run-on-projects: []
     shipping-phase: ship
-    worker-type: b-linux
+    worker-type: succeed
     worker:
-        implementation: docker-worker
-        os: linux
-        docker-image: "ubuntu:16.10"
-        max-run-time: 600
-        command:
-            - /bin/bash
-            - -c
-            - echo "Dummy task"
+        implementation: succeed
     notifications:
         emails:
             by-project:
                 mozilla-(beta|release|esr.*): ["release-signoff@mozilla.org"]
                 try: ["{config[params][owner]}"]
                 default: []
 
 jobs:
--- a/taskcluster/ci/release-partner-repack-chunking-dummy/kind.yml
+++ b/taskcluster/ci/release-partner-repack-chunking-dummy/kind.yml
@@ -28,18 +28,11 @@ only-for-build-platforms:
     - linux64-nightly/opt
 
 job-template:
     shipping-phase: promote
     shipping-product: firefox
     name: release-partner-repack-chunking-dummy
     description: Dummy task to deal with fanning out Linux partner repacks
     run-on-projects: []
-    worker-type: b-linux
+    worker-type: succeed
     worker:
-        implementation: docker-worker
-        os: linux
-        docker-image: "ubuntu:16.10"
-        max-run-time: 600
-        command:
-            - /bin/bash
-            - -c
-            - echo "Dummy task"
+        implementation: succeed
--- a/taskcluster/ci/release-secondary-notify-ship/kind.yml
+++ b/taskcluster/ci/release-secondary-notify-ship/kind.yml
@@ -13,26 +13,19 @@ kind-dependencies:
     - release-secondary-balrog-scheduling
     - push-apk
 
 job-defaults:
     name: notify-release-drivers-ship
     description: Sends email to release-drivers telling release was shipped.
     run-on-projects: []
     shipping-phase: ship
-    worker-type: b-linux
+    worker-type: succeed
     worker:
-        implementation: docker-worker
-        os: linux
-        docker-image: "ubuntu:16.10"
-        max-run-time: 600
-        command:
-            - /bin/bash
-            - -c
-            - echo "Dummy task"
+        implementation: succeed
     notifications:
         emails:
             by-project:
                 mozilla-beta: ["release-signoff@mozilla.org"]
                 mozilla-release: ["release-signoff@mozilla.org"]
                 try: ["{config[params][owner]}"]
                 default: []
 
--- a/taskcluster/taskgraph/transforms/task.py
+++ b/taskcluster/taskgraph/transforms/task.py
@@ -1272,17 +1272,19 @@ def build_treescript_payload(config, tas
 })
 def build_invalid_payload(config, task, task_def):
     task_def['payload'] = 'invalid task - should never be created'
 
 
 @payload_builder('always-optimized', schema={
     Extra: object,
 })
-def build_always_optimized_payload(config, task, task_def):
+@payload_builder('succeed', schema={
+})
+def build_dummy_payload(config, task, task_def):
     task_def['payload'] = {}
 
 
 @payload_builder('script-engine-autophone', schema={
     Required('os'): Any('macosx', 'linux'),
 
     # A link for an executable to download
     Optional('context'): basestring,