Backed out changeset 29e1fceaf48d (bug 1193394)
☠☠ backed out by a416b0a21b13 ☠ ☠
authorTooru Fujisawa <arai_a@mac.com>
Thu, 01 Mar 2018 19:55:08 +0900
changeset 461048 a0e26f6b2784e7946f166dbaed90861342fa6fb1
parent 460999 e3ea96705280635679da1265c022ba8e4b206e1d
child 461049 0e7140a7c841c3b74b70d050636a01b9d4619b56
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1193394
milestone60.0a1
backs out29e1fceaf48d9a09662a18789d034f3093c4b5e8
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 29e1fceaf48d (bug 1193394)
browser/components/customizableui/PanelMultiView.jsm
--- a/browser/components/customizableui/PanelMultiView.jsm
+++ b/browser/components/customizableui/PanelMultiView.jsm
@@ -1313,20 +1313,16 @@ var PanelView = class extends this.Assoc
         }
 
         items.push({ element });
       }
     };
     if (allowSyncReflows) {
       collectItems();
     } else {
-      // FIXME: Need to wait for the next tick, due to the collision with
-      //        bug 1193394
-      await new Promise(r => Services.tm.dispatchToMainThread(r));
-
       await this.window.promiseDocumentFlushed(collectItems);
     }
 
     // Removing the 'height' property will only cause a layout flush in the next
     // loop below if it was set.
     for (let item of items) {
       item.element.style.removeProperty("height");
     }
@@ -1336,20 +1332,16 @@ var PanelView = class extends this.Assoc
     let measureItems = () => {
       for (let item of items) {
         item.bounds = item.element.getBoundingClientRect();
       }
     };
     if (allowSyncReflows) {
       measureItems();
     } else {
-      // FIXME: Need to wait for the next tick, due to the collision with
-      //        bug 1193394
-      await new Promise(r => Services.tm.dispatchToMainThread(r));
-
       await this.window.promiseDocumentFlushed(measureItems);
     }
 
     // Now we can make all the necessary DOM changes at once.
     for (let { element, bounds } of items) {
       gMultiLineElementsMap.set(element, { bounds, textContent: element.textContent });
       element.style.height = bounds.height + "px";
     }