Bug 1493071 Rename bouncer_check cron task r=mtabara
authorSimon Fraser <sfraser@mozilla.com>
Mon, 24 Sep 2018 16:01:45 +0000
changeset 496360 a09f0857ea6718e13f44fd7753e5818940f542b6
parent 496359 e9f354569cc1a8cf8639131feb0368f68b80375c
child 496361 d3d5149546bf7f6a533a9cd39832278c8cde064d
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmtabara
bugs1493071
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1493071 Rename bouncer_check cron task r=mtabara Differential Revision: https://phabricator.services.mozilla.com/D6660
.cron.yml
taskcluster/ci/bouncer-check/kind.yml
taskcluster/ci/cron-bouncer-check/kind.yml
taskcluster/docs/kinds.rst
taskcluster/taskgraph/target_tasks.py
taskcluster/taskgraph/transforms/bouncer_check.py
--- a/.cron.yml
+++ b/.cron.yml
@@ -101,17 +101,17 @@ jobs:
           by-project:
               mozilla-central: [{hour: 10, minute: 30}]
               # No default
 
     - name: bouncer-check
       job:
           type: decision-task
           treeherder-symbol: Rel
-          target-tasks-method: bouncer_check
+          target-tasks-method: cron_bouncer_check
       run-on-projects:
           - mozilla-beta
           - mozilla-release
       when:
           by-project:
               # No default branch
               mozilla-beta:
                   - {hour: 7, minute: 0}
rename from taskcluster/ci/bouncer-check/kind.yml
rename to taskcluster/ci/cron-bouncer-check/kind.yml
--- a/taskcluster/ci/bouncer-check/kind.yml
+++ b/taskcluster/ci/cron-bouncer-check/kind.yml
@@ -8,17 +8,16 @@ transforms:
     - taskgraph.transforms.bouncer_check:transforms
     - taskgraph.transforms.job:transforms
     - taskgraph.transforms.task:transforms
 
 job-defaults:
     name: bouncer-check
     description: bouncer check
     run-on-projects: []  # to make sure this never runs as part of CI
-    shipping-phase: push
     worker-type: aws-provisioner-v1/gecko-{level}-b-linux
     worker:
         max-run-time: 1200
         docker-image: {in-tree: "update-verify"}
     run:
         using: run-task
         sparse-profile: mozharness
     attributes:
--- a/taskcluster/docs/kinds.rst
+++ b/taskcluster/docs/kinds.rst
@@ -302,18 +302,18 @@ Submits bouncer updates for releases.
 release-mark-as-shipped
 -----------------------
 Marks releases as shipped in Ship-It v1
 
 release-bouncer-aliases
 -----------------------
 Update Bouncer's (download.mozilla.org) "latest" aliases.
 
-bouncer-check
--------------
+cron-bouncer-check
+------------------
 Checks Bouncer (download.mozilla.org) uptake.
 
 bouncer-locations
 -----------------
 Updates nightly bouncer locations for version bump
 
 release-bouncer-check
 ---------------------
--- a/taskcluster/taskgraph/target_tasks.py
+++ b/taskcluster/taskgraph/target_tasks.py
@@ -588,16 +588,16 @@ def target_tasks_file_update(full_task_g
     """Select the set of tasks required to perform nightly in-tree file updates
     """
     def filter(task):
         # For now any task in the repo-update kind is ok
         return task.kind in ['repo-update']
     return [l for l, t in full_task_graph.tasks.iteritems() if filter(t)]
 
 
-@_target_task('bouncer_check')
+@_target_task('cron_bouncer_check')
 def target_tasks_bouncer_check(full_task_graph, parameters, graph_config):
     """Select the set of tasks required to perform bouncer version verification.
     """
     def filter(task):
         # For now any task in the repo-update kind is ok
-        return task.kind in ['bouncer-check']
+        return task.kind in ['cron-bouncer-check']
     return [l for l, t in full_task_graph.tasks.iteritems() if filter(t)]
--- a/taskcluster/taskgraph/transforms/bouncer_check.py
+++ b/taskcluster/taskgraph/transforms/bouncer_check.py
@@ -65,17 +65,17 @@ def handle_keyed_by(config, jobs):
         job = copy.deepcopy(job)  # don't overwrite dict values here
         for field in fields:
             resolve_keyed_by(item=job, field=field, item_name=job['name'],
                              project=config.params['project'])
 
         for cfg in job["run"]["config"]:
             job["run"]["command"].extend(["--config", cfg])
 
-        if config.kind == "bouncer-check":
+        if config.kind == "cron-bouncer-check":
             job["run"]["command"].extend([
                 "--product-field={}".format(job["run"]["product-field"]),
                 "--products-url={}".format(job["run"]["products-url"]),
             ])
             del job["run"]["product-field"]
             del job["run"]["products-url"]
         elif config.kind == "release-bouncer-check":
             job["run"]["command"].append("--version={}".format(version))