Bug 1577467 - Remove obsolete iframe container for DevTools animation inspector; r=daisuke
authorRazvan Caliman <rcaliman@mozilla.com>
Fri, 30 Aug 2019 12:17:05 +0000
changeset 554633 a07e1432deaab8acf7a4a090f2365cfcd86c5d22
parent 554632 6e6f9cf6ea5861630bf0570ae6667660b583bc70
child 554634 19e21bdb79cbfdc5b3a9c2323d3fcb6e28f159cc
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdaisuke
bugs1577467
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1577467 - Remove obsolete iframe container for DevTools animation inspector; r=daisuke The animation inspector is [loaded on demand by the inspector](https://searchfox.org/mozilla-central/rev/8ea946dcf51f0d6400362cc1d49c8d4808e`eacf1/devtools/client/inspector/inspector.js#937-942) as a sidebar panel via an `InspectorPanel` instance. The iframe container from index.xhtml seems to be a leftover from a time where the animation inspector was loaded differently. No failing tests after removing iframe. Is this ok to cleanup? Differential Revision: https://phabricator.services.mozilla.com/D43951
devtools/client/inspector/components/InspectorTabPanel.css
devtools/client/inspector/index.xhtml
devtools/client/themes/inspector.css
--- a/devtools/client/inspector/components/InspectorTabPanel.css
+++ b/devtools/client/inspector/components/InspectorTabPanel.css
@@ -1,14 +1,8 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-.devtools-inspector-tab-frame {
-  border: none;
-  height: 100%;
-  width: 100%;
-}
-
 .devtools-inspector-tab-panel {
   width: 100%;
   height: 100%;
 }
--- a/devtools/client/inspector/index.xhtml
+++ b/devtools/client/inspector/index.xhtml
@@ -134,17 +134,13 @@
 
         <div id="computed-container">
           <div id="computed-container-focusable" tabindex="-1">
             <div id="computed-property-container" class="devtools-monospace" tabindex="0" dir="ltr"></div>
             <div id="computed-no-results" class="devtools-sidepanel-no-result" hidden="" data-localization="content=inspector.noProperties"></div>
           </div>
         </div>
       </div>
-
-      <div id="sidebar-panel-animationinspector" class="theme-sidebar inspector-tabpanel">
-        <iframe class="devtools-inspector-tab-frame"></iframe>
-      </div>
     </div>
 
   </div>
 </body>
 </html>
--- a/devtools/client/themes/inspector.css
+++ b/devtools/client/themes/inspector.css
@@ -186,14 +186,8 @@ iframe {
   flex: 1;
   min-height: 0;
 }
 
 #markup-box > iframe {
   height: 100%;
   width: 100%;
 }
-
-/* Animation inspector */
-#sidebar-panel-animationinspector {
-  height: 100%;
-  width: 100%;
-}