Bug 1441878 - Remove unused css variable theme-codemirror-gutter-background;r=ntim
authorJulian Descottes <jdescottes@mozilla.com>
Mon, 27 Aug 2018 09:46:28 +0000
changeset 491206 a0736ba18fe4b6909cc581d9495ecb034c3bfad5
parent 491205 68454690d5b06835f541ef2477a5844e875be3c2
child 491207 34d91e45491b140ea7077b0ecbe32ce8a0301bff
push id1815
push userffxbld-merge
push dateMon, 15 Oct 2018 10:40:45 +0000
treeherdermozilla-release@18d4c09e9378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersntim
bugs1441878
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1441878 - Remove unused css variable theme-codemirror-gutter-background;r=ntim This variable is no longer used anywhere and can be removed Differential Revision: https://phabricator.services.mozilla.com/D4309
browser/base/content/test/static/browser_parsable_css.js
devtools/client/themes/variables.css
--- a/browser/base/content/test/static/browser_parsable_css.js
+++ b/browser/base/content/test/static/browser_parsable_css.js
@@ -95,19 +95,16 @@ let propNameWhitelist = [
   // These are CSS custom properties that we found a definition of but
   // no reference to.
   // Bug 1441837
   {propName: "--in-content-category-text-active",
    isFromDevTools: false},
   // Bug 1441929
   {propName: "--theme-search-overlays-semitransparent",
    isFromDevTools: true},
-  // Bug 1441878
-  {propName: "--theme-codemirror-gutter-background",
-   isFromDevTools: true},
   // These custom properties are retrieved directly from CSSOM
   // in videocontrols.xml to get pre-defined style instead of computed
   // dimensions, which is why they are not referenced by CSS.
   {propName: "--clickToPlay-width",
    isFromDevTools: false},
   {propName: "--playButton-width",
    isFromDevTools: false},
   {propName: "--muteButton-width",
--- a/devtools/client/themes/variables.css
+++ b/devtools/client/themes/variables.css
@@ -97,17 +97,16 @@
   --theme-arrowpanel-background: -moz-field;
   --theme-arrowpanel-color: -moz-fieldText;
   --theme-arrowpanel-border-color: ThreeDShadow;
   --theme-arrowpanel-separator: ThreeDShadow;
   --theme-arrowpanel-dimmed: hsla(0,0%,80%,.3);
   --theme-arrowpanel-dimmed-further: hsla(0,0%,80%,.45);
   --theme-arrowpanel-disabled-color: GrayText;
 
-  --theme-codemirror-gutter-background: #f4f4f4;
   --theme-messageCloseButtonFilter: invert(0);
 }
 
 /*
  * For doorhangers elsewhere in Firefox, Mac uses fixed colors rather than
  * system colors.
  */
 :root[platform="mac"].theme-light {
@@ -200,17 +199,16 @@
   --theme-arrowpanel-background: var(--grey-60);
   --theme-arrowpanel-color: rgb(249,249,250);
   --theme-arrowpanel-border-color: #27272b;
   --theme-arrowpanel-separator: rgba(249,249,250,.1);
   --theme-arrowpanel-dimmed: rgba(249,249,250,.1);
   --theme-arrowpanel-dimmed-further: rgba(249,249,250,.15);
   --theme-arrowpanel-disabled-color: rgba(249,249,250,.5);
 
-  --theme-codemirror-gutter-background: #262b37;
   --theme-messageCloseButtonFilter: invert(1);
 }
 
 :root {
   --theme-focus-border-color-textbox: #0675d3;
   --theme-textbox-box-shadow: rgba(97,181,255,.75);
 
   /* For accessibility purposes we want to enhance the focus styling. This