Bug 1510689. Only define IsNonConfigurableReadonlyPrimitiveGlobalProp if we plan to use it. r=peterv a=Aryx,beta-fix FIREFOX_BETA_65_BASE
authorBoris Zbarsky <bzbarsky@mit.edu>
Mon, 03 Dec 2018 16:14:15 +0200
changeset 508428 9ad82455dcee2bc1d438e46016b8db00e88758a8
parent 508427 01d0813d8203d78613fc33a3e8e32627c1300b50
child 508429 60b122ce38e6f529db79fd61db75ee8a8c6f3011
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspeterv, Aryx, beta-fix
bugs1510689
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510689. Only define IsNonConfigurableReadonlyPrimitiveGlobalProp if we plan to use it. r=peterv a=Aryx,beta-fix
dom/base/nsGlobalWindowOuter.cpp
--- a/dom/base/nsGlobalWindowOuter.cpp
+++ b/dom/base/nsGlobalWindowOuter.cpp
@@ -482,22 +482,24 @@ bool nsOuterWindowProxy::getPropertyDesc
  * 2) The property is non-configurable.
  * 3) The property is non-writable (readonly).
  * 4) The value of the property is a primitive (so doesn't change
  *    observably on when navigation happens).
  *
  * Such properties can act as actual non-configurable properties on a
  * WindowProxy, because they are not affected by navigation.
  */
+#ifndef RELEASE_OR_BETA
 static bool IsNonConfigurableReadonlyPrimitiveGlobalProp(JSContext* cx,
                                                          JS::Handle<jsid> id) {
   return id == GetJSIDByIndex(cx, XPCJSContext::IDX_NAN) ||
          id == GetJSIDByIndex(cx, XPCJSContext::IDX_UNDEFINED) ||
          id == GetJSIDByIndex(cx, XPCJSContext::IDX_INFINITY);
 }
+#endif
 
 bool nsOuterWindowProxy::getOwnPropertyDescriptor(
     JSContext* cx, JS::Handle<JSObject*> proxy, JS::Handle<jsid> id,
     JS::MutableHandle<JS::PropertyDescriptor> desc) const {
   bool found;
   if (!GetSubframeWindow(cx, proxy, id, desc.value(), found)) {
     return false;
   }