Bug 1500164 - Allow selecting text in add-on release notes r=jaws
authorMark Striemer <mstriemer@mozilla.com>
Fri, 19 Oct 2018 19:41:02 +0000
changeset 500747 9eefd490403607a910d9805665b8f2a6d3a32c49
parent 500746 b2a4b8894c2a0c396ebe118a52490f514f3a5bb2
child 500748 2d8a1d405333036b4adce643e4893f2da29957be
child 500759 3872ebc4799bf8e606006f36444e021dddad0825
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1500164
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1500164 - Allow selecting text in add-on release notes r=jaws Differential Revision: https://phabricator.services.mozilla.com/D9139
toolkit/mozapps/extensions/content/extensions.xml
toolkit/themes/shared/extensions/extensions.inc.css
--- a/toolkit/mozapps/extensions/content/extensions.xml
+++ b/toolkit/mozapps/extensions/content/extensions.xml
@@ -1487,17 +1487,19 @@
             this._updateState();
         ]]></body>
       </method>
     </implementation>
 
     <handlers>
       <handler event="click" button="0"><![CDATA[
         if (!["button", "checkbox", "menulist", "menuitem"].includes(event.originalTarget.localName) &&
-            !event.originalTarget.classList.contains("text-link")) {
+            !event.originalTarget.classList.contains("text-link") &&
+            // Treat the relnotes container as embedded text instead of a click target.
+            !event.originalTarget.closest(".relnotes-container")) {
           this.showInDetailView();
         }
       ]]></handler>
     </handlers>
   </binding>
 
 
   <!-- Addon - uninstalled - An uninstalled addon that can be re-installed. -->
--- a/toolkit/themes/shared/extensions/extensions.inc.css
+++ b/toolkit/themes/shared/extensions/extensions.inc.css
@@ -359,16 +359,20 @@ richlistbox.list > richlistitem.addon {
   filter: grayscale(1);
 }
 
 .addon label,
 .addon {
   cursor: pointer;
 }
 
+.relnotes-container {
+  cursor: auto;
+}
+
 .addon-view[type="theme"] .icon {
   list-style-image: url("chrome://mozapps/skin/extensions/themeGeneric.svg");
 }
 
 .addon-view[type="locale"] .icon {
   list-style-image: url("chrome://mozapps/skin/extensions/localeGeneric.svg");
 }