Bug 1434922 - Set a favicon for about:privatebrowsing. r=florian a=RyanVM
authorJohann Hofmann <jhofmann@mozilla.com>
Sun, 04 Feb 2018 11:52:23 +0100
changeset 454724 9dbb3d090a27b36a5a11e14621c4c37b44e8f410
parent 454723 e8928484234d092ea9e5d6771c296d0a42a8b3da
child 454725 f235b6c433a899562b3ee38edd12a3b1eba17666
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersflorian, RyanVM
bugs1434922
milestone59.0
Bug 1434922 - Set a favicon for about:privatebrowsing. r=florian a=RyanVM This was initially removed when we added support for setting the favicon ahead of parsing the page for newtab-like pages. Turns out we need it in some scenarios, such as navigating back and forth or duplicating the tab. MozReview-Commit-ID: HuMeEnqpLLB
browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml
--- a/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml
+++ b/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml
@@ -14,17 +14,17 @@
   <!ENTITY % browserDTD SYSTEM "chrome://browser/locale/browser.dtd">
   %browserDTD;
   <!ENTITY % aboutPrivateBrowsingDTD SYSTEM "chrome://browser/locale/aboutPrivateBrowsing.dtd">
   %aboutPrivateBrowsingDTD;
 ]>
 
 <html xmlns="http://www.w3.org/1999/xhtml" class="private">
   <head>
-    <link id="favicon" rel="icon" type="image/png"/>
+    <link id="favicon" rel="icon" type="image/png" href="chrome://browser/skin/privatebrowsing/favicon.svg"/>
     <link rel="stylesheet" href="chrome://browser/content/aboutPrivateBrowsing.css" type="text/css" media="all"/>
     <link rel="stylesheet" href="chrome://browser/skin/privatebrowsing/aboutPrivateBrowsing.css" type="text/css" media="all"/>
     <script type="application/javascript" src="chrome://browser/content/aboutPrivateBrowsing.js"></script>
   </head>
 
   <body dir="&locale.dir;">
     <p class="showNormal">&aboutPrivateBrowsing.notPrivate;</p>
     <button xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"