Bug 1434619 - servo: Remove #![deny(warnings)]. r=nox, a=lizzard
authorSimon Sapin <simon.sapin@exyr.org>
Wed, 31 Jan 2018 11:01:26 -0600
changeset 454671 9c48b0136c8aa07f8dd8abf0af06dd331652776d
parent 454670 60dacc12cab137a14e82a1ae7c070b520919cf8e
child 454672 d4c3d0d6a6f9cd9375d0592fb85b8262371bfe8d
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnox, lizzard
bugs1434619
milestone59.0
Bug 1434619 - servo: Remove #![deny(warnings)]. r=nox, a=lizzard We already have https://github.com/servo/servo/pull/19612 to deny warnings at the time of landing into master. But it’s not useful to break the build when later compiler with a more recent Rust version that has introduced new warnings: Source-Repo: https://github.com/servo/servo Source-Revision: 7546c37f1e921a112fef5828c59c6738a98c3f30
servo/components/style/lib.rs
servo/ports/geckolib/lib.rs
servo/support/gecko/nsstring/src/lib.rs
--- a/servo/components/style/lib.rs
+++ b/servo/components/style/lib.rs
@@ -18,17 +18,16 @@
 //! [recalc_style_at]: traversal/fn.recalc_style_at.html
 //!
 //! Major dependencies are the [cssparser][cssparser] and [selectors][selectors]
 //! crates.
 //!
 //! [cssparser]: ../cssparser/index.html
 //! [selectors]: ../selectors/index.html
 
-#![deny(warnings)]
 #![deny(missing_docs)]
 
 #![recursion_limit = "500"]  // For define_css_keyword_enum! in -moz-appearance
 
 extern crate app_units;
 extern crate arrayvec;
 extern crate atomic_refcell;
 #[macro_use]
--- a/servo/ports/geckolib/lib.rs
+++ b/servo/ports/geckolib/lib.rs
@@ -1,13 +1,12 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-#![deny(warnings)]
 
 extern crate cssparser;
 extern crate env_logger;
 extern crate libc;
 #[macro_use] extern crate log;
 extern crate malloc_size_of;
 extern crate selectors;
 extern crate servo_arc;
--- a/servo/support/gecko/nsstring/src/lib.rs
+++ b/servo/support/gecko/nsstring/src/lib.rs
@@ -108,17 +108,16 @@
 //! similar to an `ns[C]String`, however, it does not have a `Drop`
 //! implementation.
 //!
 //! If this type is dropped in rust, it will not free its backing storage. This
 //! can be useful when implementing FFI types which contain `ns[C]String` members
 //! which invoke their member's destructors through C++ code.
 
 #![allow(non_camel_case_types)]
-#![deny(warnings)]
 
 #[macro_use]
 extern crate bitflags;
 
 use std::borrow;
 use std::cmp;
 use std::fmt;
 use std::marker::PhantomData;