Bug 1456768 - [BinAST] Properly set pn->op for non-spread new expressions. (r=Yoric)
authorEric Faust <efaustbmo@gmail.com>
Mon, 30 Apr 2018 20:44:53 -0700
changeset 472506 9bf70e179625ca212595e8fe8cd51b237fe99039
parent 472505 32f1ddc878092d0f15517e1ed5e17ce19293a3ff
child 472507 42c4d4acfba5d5c07e9f95c61c737b626d37c994
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersYoric
bugs1456768
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1456768 - [BinAST] Properly set pn->op for non-spread new expressions. (r=Yoric)
js/src/frontend/BinSource-auto.cpp
js/src/frontend/BinSource.yaml
--- a/js/src/frontend/BinSource-auto.cpp
+++ b/js/src/frontend/BinSource-auto.cpp
@@ -5847,16 +5847,17 @@ BinASTParser<Tok>::parseInterfaceNewExpr
 
 
     BINJS_MOZ_TRY_DECL(arguments, parseArguments());
 
 
     auto result = arguments;
     result->setKind(ParseNodeKind::New);
     result->prepend(callee);
+    result->setOp(JSOP_NEW);
     return result;
 }
 
 
 /*
  interface NewTargetExpression : Node {
  }
 */
--- a/js/src/frontend/BinSource.yaml
+++ b/js/src/frontend/BinSource.yaml
@@ -811,16 +811,17 @@ LiteralStringExpression:
     build:
         BINJS_TRY_DECL(result, factory_.newStringLiteral(value, tokenizer_->pos(start)));
 
 NewExpression:
     build: |
         auto result = arguments;
         result->setKind(ParseNodeKind::New);
         result->prepend(callee);
+        result->setOp(JSOP_NEW);
 
 ObjectExpression:
     build:
         auto result = properties;
 
 OptionalAssertedBlockScope:
     type-ok:
         Ok