Bug 1341102 - Make stylo reftests green; r=orange
authorManish Goregaokar <manishearth@gmail.com>
Sat, 04 Mar 2017 13:06:34 -0800
changeset 394918 9beaa662eb45e43fb5bd030660bad8efc2c8d7bc
parent 394917 473acbe8453d4b763b173539db1954c3d7efb9e1
child 394919 84c1dd84d182a55e5a8367c563a78635486edc07
push id1468
push userasasaki@mozilla.com
push dateMon, 05 Jun 2017 19:31:07 +0000
treeherdermozilla-release@0641fc6ee9d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersorange
bugs1341102
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1341102 - Make stylo reftests green; r=orange MozReview-Commit-ID: 2TeGOXp3DuV
layout/reftests/box/reftest-stylo.list
layout/reftests/bugs/reftest-stylo.list
layout/reftests/font-inflation/reftest-stylo.list
layout/reftests/webkit-box/reftest-stylo.list
layout/style/test/stylo-failures.md
--- a/layout/reftests/box/reftest-stylo.list
+++ b/layout/reftests/box/reftest-stylo.list
@@ -1,12 +1,12 @@
 # DO NOT EDIT! This is a auto-generated temporary list for Stylo testing
 == flexbox-abspos-container-1a.html flexbox-abspos-container-1a.html
 == flexbox-abspos-container-1b.html flexbox-abspos-container-1b.html
 == flexbox-abspos-container-1c.html flexbox-abspos-container-1c.html
 == flexbox-abspos-container-1d.html flexbox-abspos-container-1d.html
 == flexbox-abspos-container-2.html flexbox-abspos-container-2.html
 == flexbox-attributes-no-box-horizontal.xhtml flexbox-attributes-no-box-horizontal.xhtml
-fails == flexbox-attributes-no-box-vertical.xhtml flexbox-attributes-no-box-vertical.xhtml
+== flexbox-attributes-no-box-vertical.xhtml flexbox-attributes-no-box-vertical.xhtml
 fails == flexbox-attributes-no-input-horizontal.xhtml flexbox-attributes-no-input-horizontal.xhtml
 fails == flexbox-attributes-no-input-vertical.xhtml flexbox-attributes-no-input-vertical.xhtml
 == flexbox-child-is-abspos-container-1.html flexbox-child-is-abspos-container-1.html
 == flexbox-child-is-abspos-container-2.html flexbox-child-is-abspos-container-2.html
--- a/layout/reftests/bugs/reftest-stylo.list
+++ b/layout/reftests/bugs/reftest-stylo.list
@@ -1719,17 +1719,17 @@ fails == 720987.html 720987.html
 fails == 729143-1.html 729143-1.html
 fails == 731521-1.html 731521-1.html
 fails needs-focus == 731726-1.html 731726-1.html
 fails == 735481-1.html 735481-1.html
 == 745934-1.html 745934-1.html
 fails == 748692-1a.html 748692-1a.html
 fails == 748692-1b.html 748692-1b.html
 fails == 748803-1.html 748803-1.html
-fails == 750551-1.html 750551-1.html
+== 750551-1.html 750551-1.html
 fails == 751012-1a.html 751012-1a.html
 fails == 751012-1b.html 751012-1b.html
 == 753329-1.html 753329-1.html
 == 758561-1.html 758561-1.html
 == 759036-1.html 759036-1.html
 fails == 759036-2.html 759036-2.html
 fails == 776265-1a.html 776265-1a.html
 fails == 776265-1b.html 776265-1b.html
--- a/layout/reftests/font-inflation/reftest-stylo.list
+++ b/layout/reftests/font-inflation/reftest-stylo.list
@@ -101,12 +101,12 @@ fails == threshold-select-combobox-conte
 fails == threshold-select-combobox-contents-at-1.html threshold-select-combobox-contents-at-1.html
 fails == threshold-select-combobox-contents-at-2.html threshold-select-combobox-contents-at-2.html
 
 pref(font.size.inflation.emPerLine,15) pref(font.size.inflation.forceEnabled,true) pref(font.size.inflation.lineThreshold,0) == relevant-width-1.html relevant-width-1.html
 pref(font.size.inflation.emPerLine,15) pref(font.size.inflation.forceEnabled,true) pref(font.size.inflation.lineThreshold,0) == relevant-width-overflow-1.html relevant-width-overflow-1.html
 
 fails pref(font.size.inflation.emPerLine,15) pref(font.size.inflation.forceEnabled,true) pref(font.size.inflation.lineThreshold,0) == min-width-passes-1.html min-width-passes-1.html
 
-fails pref(font.size.inflation.emPerLine,15) pref(font.size.inflation.forceEnabled,true) == xul-reflow-1.html xul-reflow-1.html
+pref(font.size.inflation.emPerLine,15) pref(font.size.inflation.forceEnabled,true) == xul-reflow-1.html xul-reflow-1.html
 
 # reset the default preferences
 default-preferences
--- a/layout/reftests/webkit-box/reftest-stylo.list
+++ b/layout/reftests/webkit-box/reftest-stylo.list
@@ -6,39 +6,39 @@ default-preferences pref(layout.css.pref
 # Tests for anonymous flex item formation inside of a "-webkit-box":
 # Note: some of these tests are marked as failing, because we don't match
 # WebKit/Blink on them.  (The reference case represents the WebKit/Blink
 # rendering.) We could probably make them pass by implementing some quirks, if
 # it turns out that the web depends on WebKit/Blink's behavior in these cases.
 fails == webkit-box-anon-flex-items-1a.html webkit-box-anon-flex-items-1a.html
 fails == webkit-box-anon-flex-items-1b.html webkit-box-anon-flex-items-1b.html
 == webkit-box-anon-flex-items-2.html webkit-box-anon-flex-items-2.html
-fails == webkit-box-anon-flex-items-3.html webkit-box-anon-flex-items-3.html
+== webkit-box-anon-flex-items-3.html webkit-box-anon-flex-items-3.html
 
 # Tests for "-webkit-box" & "-webkit-inline-box" as display values:
-fails == webkit-display-values-1.html webkit-display-values-1.html
+== webkit-display-values-1.html webkit-display-values-1.html
 
 # Tests for "-webkit-box-align" (cross-axis alignment):
 == webkit-box-align-horiz-1a.html webkit-box-align-horiz-1a.html
 == webkit-box-align-horiz-1b.html webkit-box-align-horiz-1b.html
-fails == webkit-box-align-vert-1.html webkit-box-align-vert-1.html
+== webkit-box-align-vert-1.html webkit-box-align-vert-1.html
 
 # Tests for "-webkit-box-direction":
-fails == webkit-box-direction-1.html webkit-box-direction-1.html
-fails == webkit-box-direction-2.html webkit-box-direction-2.html
+== webkit-box-direction-1.html webkit-box-direction-1.html
+== webkit-box-direction-2.html webkit-box-direction-2.html
 
 # Tests for "-webkit-box-flex" (flexibility of items)
 == webkit-box-flex-1.html webkit-box-flex-1.html
 
 # Tests for "-webkit-box-ordinal-group"
 fails == webkit-box-ordinal-group-1.html webkit-box-ordinal-group-1.html
 # XXXdholbert The following test fails because we accept "0" as a valid value
 # for -webkit-box-ordinal-group (unlike Chrome/Blink), because that's simply
 # how its aliased property (-moz-box-ordinal-group) behaves. This shouldn't
 # matter in practice; it could only cause trouble if sites accidentally depend
 # on the "0" value being rejected.
 fails == webkit-box-ordinal-group-2.html webkit-box-ordinal-group-2.html
 fails == webkit-box-ordinal-group-3.html webkit-box-ordinal-group-3.html
 
 # Tests for "-webkit-box-pack" (main-axis alignment):
-fails == webkit-box-pack-horiz-1a.html webkit-box-pack-horiz-1a.html
-fails == webkit-box-pack-horiz-1b.html webkit-box-pack-horiz-1b.html
-fails == webkit-box-pack-vert-1.html webkit-box-pack-vert-1.html
+== webkit-box-pack-horiz-1a.html webkit-box-pack-horiz-1a.html
+== webkit-box-pack-horiz-1b.html webkit-box-pack-horiz-1b.html
+== webkit-box-pack-vert-1.html webkit-box-pack-vert-1.html
--- a/layout/style/test/stylo-failures.md
+++ b/layout/style/test/stylo-failures.md
@@ -187,21 +187,21 @@ Any line which doesn't follow the format
     * test_compute_data_with_start_struct.html `-colors` [8]
     * test_inherit_computation.html `-colors` [8]
     * test_inherit_storage.html `-colors` [12]
     * test_initial_computation.html `-colors` [16]
     * test_initial_storage.html `-colors` [24]
     * test_value_storage.html `-colors` [96]
     * test_shorthand_property_getters.html `-colors` [1]
   * -moz-box-{direction,ordinal-group,orient,pack}
-    * test_compute_data_with_start_struct.html `-moz-box-` [8]
-    * test_inherit_computation.html `-box-` [16]
-    * test_inherit_storage.html `-box-` [20]
-    * test_initial_computation.html `-box-` [32]
-    * test_initial_storage.html `-box-` [40]
+    * test_compute_data_with_start_struct.html `-moz-box-` [2]
+    * test_inherit_computation.html `-box-` [4]
+    * test_inherit_storage.html `-box-` [5]
+    * test_initial_computation.html `-box-` [8]
+    * test_initial_storage.html `-box-` [10]
     * test_value_storage.html `-box-` [172]
   * -moz-force-broken-image-icon
     * test_compute_data_with_start_struct.html `-moz-force-broken-image-icon` [2]
     * test_inherit_computation.html `-moz-force-broken-image-icon` [2]
     * test_inherit_storage.html `-moz-force-broken-image-icon` [2]
     * test_initial_computation.html `-moz-force-broken-image-icon` [4]
     * test_initial_storage.html `-moz-force-broken-image-icon` [4]
     * test_value_storage.html `-moz-force-broken-image-icon` [4]
@@ -417,22 +417,16 @@ Any line which doesn't follow the format
     * ... `/ auto repeat` [17]
   * border shorthands do not reset border-image servo/servo#15202
     * test_inherit_storage.html `for property 'border-image-` [5]
     * test_initial_storage.html `for property 'border-image-` [10]
     * test_value_storage.html `(for 'border-image-` [60]
   * whitespace should be required around '+'/'-' servo/servo#15486
     * test_property_syntax_errors.html `calc(2em+` [6]
     * ... `calc(50%+` [8]
-  * &lt;position&gt; value accepts invalid 3-value forms servo/servo#15488
-    * test_property_syntax_errors.html `'background-position'` [12]
-    * ... `mask-position'` [20]
-    * ... `object-position` [4]
-    * ... `circle(at ` [2]
-    * ... `ellipse(at ` [2]
   * accepts rubbish for second part of value:
     * test_property_syntax_errors.html `'text-overflow'`: servo/servo#15491 [8]
   * -moz-alt-content parsing is wrong: servo/servo#15726
     * test_property_syntax_errors.html `-moz-alt-content` [4]
   * {transform,perspective}-origin fail to parse 'center left' and 'center right' servo/servo#15750
     * test_value_storage.html `'center left'` [8]
     * ... `'center right'` [8]
 * Incorrect serialization