Bug 1053447 - Re-enable background finalization of proxies. r=terrence, a=sledru
authorEric Faust <efaustbmo@gmail.com>
Wed, 13 Aug 2014 15:23:26 -0700
changeset 217518 9b8c0def997a7b945d3b870125d34fd7fdabdaaf
parent 217517 98ec8fb73632c09688b5906f7eb8ec267b37190d
child 217519 e7bb9c0cbb403cbbcfd4b42940b3df3c7fe17d04
push id515
push userraliiev@mozilla.com
push dateMon, 06 Oct 2014 12:51:51 +0000
treeherdermozilla-release@267c7a481bef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersterrence, sledru
bugs1053447
milestone33.0a2
Bug 1053447 - Re-enable background finalization of proxies. r=terrence, a=sledru
js/src/vm/ProxyObject.cpp
--- a/js/src/vm/ProxyObject.cpp
+++ b/js/src/vm/ProxyObject.cpp
@@ -37,21 +37,19 @@ ProxyObject::New(JSContext *cx, const Ba
         RootedObject protoObj(cx, proto.toObject());
         if (!JSObject::setNewTypeUnknown(cx, clasp, protoObj))
             return nullptr;
     }
 
     NewObjectKind newKind = options.singleton() ? SingletonObject : GenericObject;
     gc::AllocKind allocKind = gc::GetGCObjectKind(clasp);
 
-#if 0
-    // Background finalization of proxies temporarily disabled. See bug 1008791
     if (handler->finalizeInBackground(priv))
         allocKind = GetBackgroundAllocKind(allocKind);
-#endif
+
     RootedObject obj(cx, NewObjectWithGivenProto(cx, clasp, proto, parent, allocKind, newKind));
     if (!obj)
         return nullptr;
 
     Rooted<ProxyObject*> proxy(cx, &obj->as<ProxyObject>());
     proxy->initHandler(handler);
     proxy->initCrossCompartmentPrivate(priv);