Bug 1265342 Part 9: Update shape-outside ellipse tests to correct invalid use of only one radius parameter. r=dholbert
☠☠ backed out by 723a9f786923 ☠ ☠
authorBrad Werth <bwerth@mozilla.com>
Wed, 14 Mar 2018 14:21:12 -0700
changeset 471527 9b200122014e2fbb0a36381bf11179fe6f584434
parent 471526 a90aa063b2fd736680ebf86a00bc2a3fc5648754
child 471528 83aee3dafe4b3625745c994b6352e94b9f96ea7b
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1265342
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1265342 Part 9: Update shape-outside ellipse tests to correct invalid use of only one radius parameter. r=dholbert https://www.w3.org/TR/css-shapes-1/#funcdef-ellipse states that the grammar for ellipse is: ellipse() = ellipse( [<shape-radius>{2}]? [at <position>]? ) This permits either 0 or 2 shape-radius tokens, but not 1. These two tests use 1 shape-radius token and do not parse correctly. https://www.w3.org/TR/css-shapes-1/#typedef-shape-radius states that omitted shape-radius values default to closest-side. This change updates these two tests to add the closest-side value for the missing shape-radius tokens. MozReview-Commit-ID: 9UKxJel1b50
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html
@@ -29,17 +29,17 @@
     }
     #test-shape {
         float: left;
         width: 140px;
         height: 140px;
         margin: 10px;
         padding: 10px;
         border: 10px solid transparent;
-        shape-outside: padding-box ellipse(closest-side at 75px 80px);
+        shape-outside: padding-box ellipse(closest-side closest-side at 75px 80px);
     }
     #line {
         position: absolute;
         top: 0px;
         left: 168px;
         width: 2px;
         height: 200px;
         border-left: 2px solid blue;
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html
@@ -31,17 +31,17 @@
     #test-shape {
         float: left;
         width: 130px;
         height: 130px;
         margin: 10px;
         padding: 10px;
         border: 10px solid transparent;
         shape-margin: 10px;
-        shape-outside: content-box ellipse(farthest-side);
+        shape-outside: content-box ellipse(farthest-side closest-side);
     }
     #line {
         position: absolute;
         top: 0px;
         left: 168px;
         width: 2px;
         height: 200px;
         border-left: 2px solid blue;