Bug 1312434 - add ContentDescription to Activity Stream menus and topsites r=sebastian
authorAndrzej Hunt <ahunt@mozilla.com>
Fri, 04 Nov 2016 10:55:54 +0100
changeset 366653 9af814b282fa915ee95329443ee42cc46943a863
parent 366652 8e56f56c09a1bc1aceeaee1d6b277f4bcf021ce5
child 366654 d58be05673a2f2ef4e1db32193611d37f1da470c
push id1369
push userjlorenzo@mozilla.com
push dateMon, 27 Feb 2017 14:59:41 +0000
treeherdermozilla-release@d75a1dba431f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1312434
milestone52.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1312434 - add ContentDescription to Activity Stream menus and topsites r=sebastian MozReview-Commit-ID: AvkG5OVSBsj
mobile/android/base/resources/layout/activity_stream_card_history_item.xml
mobile/android/base/resources/layout/activity_stream_main_toppanel.xml
mobile/android/base/resources/layout/activity_stream_topsites_card.xml
--- a/mobile/android/base/resources/layout/activity_stream_card_history_item.xml
+++ b/mobile/android/base/resources/layout/activity_stream_card_history_item.xml
@@ -33,16 +33,17 @@
             android:id="@+id/menu"
             android:layout_width="wrap_content"
             android:layout_height="20dp"
             android:layout_alignParentEnd="true"
             android:layout_alignParentRight="true"
             android:layout_alignParentTop="true"
             android:layout_gravity="right|top"
             android:padding="2dp"
+            android:contentDescription="@string/menu"
             android:layout_marginLeft="@dimen/activity_stream_base_margin"
             android:layout_marginBottom="@dimen/activity_stream_base_margin"
             android:src="@drawable/menu" />
 
         <TextView
             android:id="@+id/page"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
--- a/mobile/android/base/resources/layout/activity_stream_main_toppanel.xml
+++ b/mobile/android/base/resources/layout/activity_stream_main_toppanel.xml
@@ -6,16 +6,17 @@
     android:layout_height="wrap_content"
     android:orientation="vertical">
 
     <android.support.v4.view.ViewPager
         android:layout_marginTop="10dp"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:id="@+id/topsites_pager"
+        android:contentDescription="@string/activity_stream_topsites"
         android:layout_alignParentTop="true"
         android:layout_alignParentLeft="true"
         android:layout_alignParentStart="true"/>
 
     <org.mozilla.gecko.home.activitystream.topsites.CirclePageIndicator
         android:id="@+id/topsites_indicator"
         android:padding="10dip"
         app:fillColor="#ff9d9d9d"
--- a/mobile/android/base/resources/layout/activity_stream_topsites_card.xml
+++ b/mobile/android/base/resources/layout/activity_stream_topsites_card.xml
@@ -48,12 +48,13 @@
             android:id="@+id/menu"
             android:layout_width="wrap_content"
             android:layout_height="28dp"
             android:layout_alignParentEnd="true"
             android:layout_alignParentRight="true"
             android:layout_alignParentTop="true"
             android:layout_gravity="right|top"
             android:padding="6dp"
+            android:contentDescription="@string/menu"
             android:src="@drawable/menu" />
 
     </RelativeLayout>
 </org.mozilla.gecko.widget.FilledCardView>
\ No newline at end of file