Bug 1435282 - Make SetTestSampleTime force a sync flush. r=sotaro
authorKartikaya Gupta <kgupta@mozilla.com>
Fri, 02 Feb 2018 10:48:25 -0500
changeset 457392 9a180017296734f166349690d78c23fa4cd765cc
parent 457391 cf517d879754ca691d8d73273a05d50d5b464b7a
child 457393 665021f085e3663c9587d08a91db1261820afe03
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssotaro
bugs1435282
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1435282 - Make SetTestSampleTime force a sync flush. r=sotaro SetTestSampleTime is called from tests via the advanceTimeAndRefresh API on DOMWindowUtils, and the expectation is that after it is done, the time has been advanced and a composite has happened. So we need to ensure that is the case with WebRender as well. This fixes the issue I was seeing with test_group_hittest.html and makes it pass. MozReview-Commit-ID: 86l9mTTwD2v
gfx/layers/apz/test/mochitest/mochitest.ini
gfx/layers/ipc/CompositorBridgeParent.cpp
--- a/gfx/layers/apz/test/mochitest/mochitest.ini
+++ b/gfx/layers/apz/test/mochitest/mochitest.ini
@@ -77,9 +77,9 @@
   skip-if = (toolkit == 'android') || (toolkit == 'cocoa') # wheel events not supported on mobile, and synthesized wheel smooth-scrolling not supported on OS X
 [test_wheel_scroll.html]
   skip-if = (os == 'android') # wheel events not supported on mobile
 [test_wheel_transactions.html]
   skip-if = (toolkit == 'android') || webrender # wheel events not supported on mobile; bug 1429521 for webrender
 [test_group_overrides.html]
   skip-if = (toolkit == 'android') || webrender # wheel events not supported on mobile; bug 1429521 for webrender
 [test_group_hittest.html]
-  skip-if = (toolkit == 'android') || webrender # mouse events not supported on mobile; bug 1429521 for webrender
+  skip-if = (toolkit == 'android') # mouse events not supported on mobile
--- a/gfx/layers/ipc/CompositorBridgeParent.cpp
+++ b/gfx/layers/ipc/CompositorBridgeParent.cpp
@@ -1284,17 +1284,17 @@ CompositorBridgeParent::SetTestSampleTim
   if (aTime.IsNull()) {
     return false;
   }
 
   mIsTesting = true;
   mTestTime = aTime;
 
   if (mWrBridge) {
-    mWrBridge->FlushRenderingAsync();
+    mWrBridge->FlushRendering();
     return true;
   }
 
   bool testComposite = mCompositionManager &&
                        mCompositorScheduler->NeedsComposite();
 
   // Update but only if we were already scheduled to animate
   if (testComposite) {