Bug 1167730 - Use NS_WARN_IF_FALSE instead of NS_WARNING_ASSERTION on Fx50. a=bustage
authorRyan VanderMeulen <ryanvm@gmail.com>
Tue, 04 Oct 2016 17:51:17 -0400
changeset 350561 98f174fa9b903aca83ecfb596e13c4cadc6ac2f4
parent 350560 1deb126ed5bb1f9bc4b67867c0ca120c4ce788ae
child 350562 1aac04b95158acd6df883fcdfaae6c0927f4e365
push id1230
push userjlund@mozilla.com
push dateMon, 31 Oct 2016 18:13:35 +0000
treeherdermozilla-release@5e06e3766db2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage
bugs1167730
milestone50.0
Bug 1167730 - Use NS_WARN_IF_FALSE instead of NS_WARNING_ASSERTION on Fx50. a=bustage
netwerk/base/nsTemporaryFileInputStream.cpp
--- a/netwerk/base/nsTemporaryFileInputStream.cpp
+++ b/netwerk/base/nsTemporaryFileInputStream.cpp
@@ -212,18 +212,17 @@ nsTemporaryFileInputStream::Deserialize(
                                         const FileDescriptorArray& aFileDescriptors)
 {
   const TemporaryFileInputStreamParams& params = aParams.get_TemporaryFileInputStreamParams();
 
   uint32_t fileDescriptorIndex = params.fileDescriptorIndex();
   FileDescriptor fd;
   if (fileDescriptorIndex < aFileDescriptors.Length()) {
     fd = aFileDescriptors[fileDescriptorIndex];
-    NS_WARNING_ASSERTION(fd.IsValid(),
-                         "Received an invalid file descriptor!");
+    NS_WARN_IF_FALSE(fd.IsValid(), "Received an invalid file descriptor!");
   } else {
     NS_WARNING("Received a bad file descriptor index!");
   }
 
   if (fd.IsValid()) {
     auto rawFD = fd.ClonePlatformHandle();
     PRFileDesc* fileDesc = PR_ImportFile(PROsfd(rawFD.release()));
     if (!fileDesc) {