Bug 989752 - Fix strings in GCLI help command; r=mratcliffe
authorJoe Walker <jwalker@mozilla.com>
Sun, 08 Jun 2014 22:34:26 +0100
changeset 207724 98c8ea754cb4cd654a1c089f6d6e75d7b7e0d361
parent 207723 ee73aa7a855cabe32ed8dcba734330062001b4ce
child 207725 84277c73fd7861829bfdb6d0ee5e5e25bae9bc35
push id494
push userraliiev@mozilla.com
push dateMon, 25 Aug 2014 18:42:16 +0000
treeherdermozilla-release@a3cc3e46b571 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmratcliffe
bugs989752
milestone32.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 989752 - Fix strings in GCLI help command; r=mratcliffe
browser/locales/en-US/chrome/browser/devtools/gcli.properties
toolkit/devtools/gcli/source/lib/gcli/commands/help.js
--- a/browser/locales/en-US/chrome/browser/devtools/gcli.properties
+++ b/browser/locales/en-US/chrome/browser/devtools/gcli.properties
@@ -163,16 +163,20 @@ helpListNone=No commands starting with '
 # LOCALIZATION NOTE (helpManRequired, helpManOptional, helpManDefault): When
 # the 'help x' command wants to show the manual for the 'x' command, it needs
 # to be able to describe the parameters as either required or optional, or if
 # they have a default value.
 helpManRequired=required
 helpManOptional=optional
 helpManDefault=optional, default=%S
 
+# LOCALIZATION NOTE (helpIntro): This forms part of the output from the 'help'
+# command. 'GCLI' is a project name and should be left untranslated.
+helpIntro=GCLI is an experiment to create a highly usable command line for web developers.
+
 # LOCALIZATION NOTE: Text shown as part of the output of the 'help' command
 # when the command in question has sub-commands, before a list of the matching
 # sub-commands.
 subCommands=Sub-Commands
 
 # LOCALIZATION NOTE (contextDesc, contextManual, contextPrefixDesc): These
 # strings are used to describe the 'context' command and its 'prefix'
 # parameter. See localization comment for 'connect' for an explanation about
--- a/toolkit/devtools/gcli/source/lib/gcli/commands/help.js
+++ b/toolkit/devtools/gcli/source/lib/gcli/commands/help.js
@@ -330,23 +330,17 @@ exports.items = [
     item: 'converter',
     from: 'commandsData',
     to: 'view',
     exec: function(commandsData, context) {
       return {
         html:
           '<div>\n' +
           '  <div if="${includeIntro}">\n' +
-          '    <p>GCLI is an experiment to create a highly usable command line for web developers.</p>\n' +
-          '    <p>\n' +
-          '      Useful links:\n' +
-          '      <a href=\'https://github.com/joewalker/gcli\'>Source</a> (Apache-2.0),\n' +
-          '      <a href=\'https://github.com/joewalker/gcli/blob/master/docs/index.md\'>Documentation</a> (for users/embedders),\n' +
-          '      <a href=\'https://wiki.mozilla.org/DevTools/Features/GCLI\'>Mozilla feature page</a> (for GCLI in the web console).\n' +
-          '    </p>\n' +
+          '    <p>${l10n.helpIntro}</p>\n' +
           '  </div>\n' +
           '\n' +
           '  <p>${heading}</p>\n' +
           '\n' +
           '  <table>\n' +
           '    <tr foreach="command in ${matchingCommands}">\n' +
           '      <td class="gcli-help-name">${command.name}</td>\n' +
           '      <td class="gcli-help-arrow">-</td>\n' +
@@ -369,23 +363,19 @@ exports.items = [
   {
     // Convert a list of commands into a formatted list
     item: 'converter',
     from: 'commandsData',
     to: 'stringView',
     exec: function(commandsData, context) {
       return {
         html:
-          '<pre><span if="${includeIntro}">## Welcome to GCLI\n' +
-          '\n' +
-          'GCLI is an experiment to create a highly usable JavaScript command line for developers.\n' +
+          '<pre><span if="${includeIntro}">## ${l10n.helpIntro1}\n' +
           '\n' +
-          'Useful links:\n' +
-          '- Source (Apache-2.0): https://github.com/joewalker/gcli\n' +
-          '- Documentation: https://github.com/joewalker/gcli/blob/master/docs/index.md</span>\n' +
+          '${l10n.helpIntro}\n' +
           '\n' +
           '# ${heading}\n' +
           '\n' +
           '<loop foreach="command in ${matchingCommands}">${command.name} &#x2192; ${command.description}\n' +
           '</loop></pre>',
         options: { allowEval: true, stack: 'commandsData->stringView' },
         data: getHelpListData(commandsData, context)
       };