Bug 1497085 [wpt PR 13412] - Move a comment in TestRunnerManager.wait_finished to make more sense, a=testonly
authorPhilip Jägenstedt <philip@foolip.org>
Thu, 11 Oct 2018 09:31:39 +0000
changeset 499485 97dedc2880cb23bf939a685ea1cfd41cb1a32806
parent 499484 a0482419c5d35ee353c0ffb288c30f8ba6ee6423
child 499486 e8201978a4abad1f4c8606ddad2b53d8cc2dc8ea
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1497085, 13412
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1497085 [wpt PR 13412] - Move a comment in TestRunnerManager.wait_finished to make more sense, a=testonly Automatic update from web-platform-testsMove a comment in TestRunnerManager.wait_finished to make more sense It's certaintly not the logging that does post-stop processing, but `after_test_end` might, so the comment is accurate if moved. The comment was added in commit 7f422ef4b1b1ecf09ff7ffc94b60c6b7bf7a41b4. -- wpt-commits: a9653ad56e60b988a38262de21c0f92b5eb13183 wpt-pr: 13412
testing/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py
@@ -618,20 +618,20 @@ class TestRunnerManager(threading.Thread
             (self.pause_on_unexpected and (subtest_unexpected or is_unexpected))):
             self.logger.info("Pausing until the browser exits")
             self.send_message("wait")
         else:
             return self.after_test_end(test, restart_before_next)
 
     def wait_finished(self):
         assert isinstance(self.state, RunnerManagerState.running)
-        # The browser should be stopped already, but this ensures we do any post-stop
-        # processing
         self.logger.debug("Wait finished")
 
+        # The browser should be stopped already, but this ensures we do any
+        # post-stop processing
         return self.after_test_end(self.state.test, True)
 
     def after_test_end(self, test, restart):
         assert isinstance(self.state, RunnerManagerState.running)
         if self.run_count == self.rerun:
             test, test_group, group_metadata = self.get_next_test()
             if test is None:
                 return RunnerManagerState.stop()