Bug 1548118 Part 3 - Remove margin-bottom from column-balancing-nested-001.html and its reference. r=dbaron
authorTing-Yu Lin <tlin@mozilla.com>
Wed, 08 May 2019 03:12:18 +0000
changeset 534882 970a59a74aed7c06d25e9da071d527c86d829f9a
parent 534881 152fb420ffc57e19cd0015c5ca57421c535d1268
child 534883 cef0cd7882055d20b8db85c0d717fdd52122f577
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs1548118, 1487927
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1548118 Part 3 - Remove margin-bottom from column-balancing-nested-001.html and its reference. r=dbaron Per bug 1487927, margin-bottom value is not always rendered as expected with our column balancing algorithm. I'd like to remove it from column-balancing-nested-001.html, and add <br> to separate each cases. Differential Revision: https://phabricator.services.mozilla.com/D30287
layout/reftests/columns/column-balancing-nested-001-ref.html
layout/reftests/columns/column-balancing-nested-001.html
--- a/layout/reftests/columns/column-balancing-nested-001-ref.html
+++ b/layout/reftests/columns/column-balancing-nested-001-ref.html
@@ -11,17 +11,16 @@
         html,body {
             color:black; background-color:white; font-family:monospace; font-size:16px; padding:0; margin:0;
         }
 
   .colset {
     -moz-column-count: 2;
     -moz-column-gap: 0px;
     -moz-column-rule: 1px solid black;
-    margin-bottom:1em;
     width:30ch;
   }
   .colset.lvl2 {
     -moz-column-rule: 1px solid blue;
   }
   .colset.lvl3 {
     -moz-column-rule: 1px solid red;
   }
@@ -40,22 +39,24 @@
 </head>
 <body>
 <div class="colset">
   <p>one one one one one</p>
   <div class="colset non-balancing lvl2">
     <p>two two two two<br>two</p>
   </div>
 </div>
+<br>
 <div class="colset">
   <p>one one one one one<br>one</p>
   <div class="colset fixed-height lvl2">
     <p>two two two two two</p>
   </div>
 </div>
+<br>
 <div class="colset">
   <p>one<br>one</p>
   <div class="colset lvl2">
     <p>two</p>
     <div class="colset fixed-height lvl3">
       <p>three three three three three three</p>
     </div>
   </div>
--- a/layout/reftests/columns/column-balancing-nested-001.html
+++ b/layout/reftests/columns/column-balancing-nested-001.html
@@ -11,17 +11,16 @@
         html,body {
             color:black; background-color:white; font-family:monospace; font-size:16px; padding:0; margin:0;
         }
 
   .colset {
     -moz-column-count: 2;
     -moz-column-gap: 0px;
     -moz-column-rule: 1px solid black;
-    margin-bottom:1em;
     width:30ch;
   }
   .colset.lvl2 {
     -moz-column-rule: 1px solid blue;
   }
   .colset.lvl3 {
     -moz-column-rule: 1px solid red;
   }
@@ -36,22 +35,24 @@
 </head>
 <body>
 <div class="colset">
   <p>one one one one one</p>
   <div class="colset non-balancing lvl2">
     <p>two two two two two</p>
   </div>
 </div>
+<br>
 <div class="colset">
   <p>one one one one one<br>one</p>
   <div class="colset fixed-height lvl2">
     <p>two two two two two</p>
   </div>
 </div>
+<br>
 <div class="colset">
   <p>one<br>one</p>
   <div class="colset lvl2">
     <p>two</p>
     <div class="colset fixed-height lvl3">
       <p>three three three three three three</p>
     </div>
   </div>