Bug 1376599 - Allow annotating experiments with a type: Fix eslint issues. r=eslint-fix on a CLOSED TREE a=uplift
authorSebastian Hengst <archaeopteryx@coole-files.de>
Fri, 30 Jun 2017 21:26:28 +0200
changeset 414175 95bd58aaf67878795cdb002b418d3a1f20e6d1b8
parent 414174 e2dc26e7f164b205b8bef15da7891ea5b712d7da
child 414176 f9678179979d38200caefe0b46f78124c74e266b
push id1490
push usermtabara@mozilla.com
push dateMon, 31 Jul 2017 14:08:16 +0000
treeherdermozilla-release@70e32e6bf15e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerseslint-fix, uplift
bugs1376599
milestone55.0
Bug 1376599 - Allow annotating experiments with a type: Fix eslint issues. r=eslint-fix on a CLOSED TREE a=uplift
toolkit/components/telemetry/TelemetryEnvironment.jsm
toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js
--- a/toolkit/components/telemetry/TelemetryEnvironment.jsm
+++ b/toolkit/components/telemetry/TelemetryEnvironment.jsm
@@ -86,17 +86,17 @@ this.TelemetryEnvironment = {
    * If an annotation with the same id already exists, it will be overwritten.
    * This triggers a new subsession, subject to throttling.
    *
    * @param {String} id The id of the active experiment.
    * @param {String} branch The experiment branch.
    * @param {Object} [options] Optional object with options.
    * @param {String} [options.type=false] The specific experiment type.
    */
-  setExperimentActive(id, branch, options={}) {
+  setExperimentActive(id, branch, options = {}) {
     return getGlobal().setExperimentActive(id, branch, options);
   },
 
   /**
    * Remove an experiment annotation from the environment.
    * If the annotation exists, a new subsession will triggered.
    *
    * @param {String} id The id of the active experiment.
--- a/toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js
+++ b/toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js
@@ -1611,17 +1611,17 @@ add_task(async function test_osstrings()
 });
 
 add_task(async function test_experimentsAPI() {
   const EXPERIMENT1 = "experiment-1";
   const EXPERIMENT1_BRANCH = "nice-branch";
   const EXPERIMENT2 = "experiment-2";
   const EXPERIMENT2_BRANCH = "other-branch";
 
-  let checkExperiment = (environmentData, id, branch, type=null) => {
+  let checkExperiment = (environmentData, id, branch, type = null) => {
     Assert.ok("experiments" in environmentData,
               "The current environment must report the experiment annotations.");
     Assert.ok(id in environmentData.experiments,
               "The experiments section must contain the expected experiment id.");
     Assert.equal(environmentData.experiments[id].branch, branch,
                  "The experiment branch must be correct.");
   };