Bug 1277756 part.2 Rename TextRangeType::NS_TEXTRANGE_UNDEFINED to TextRangeType::eUninitialized r=smaug
authorMasayuki Nakano <masayuki@d-toybox.com>
Fri, 03 Jun 2016 18:32:22 +0900
changeset 341526 93278105babfbc4ad72a55fd421df8fbc47f4dc5
parent 341525 ccdb440b7b7e8e680f6c2b561fbd9db0a1214f14
child 341527 41c18a6bdd84280957714167a4f7dc2b7408167e
push id1183
push userraliiev@mozilla.com
push dateMon, 05 Sep 2016 20:01:49 +0000
treeherdermozilla-release@3148731bed45 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1277756
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1277756 part.2 Rename TextRangeType::NS_TEXTRANGE_UNDEFINED to TextRangeType::eUninitialized r=smaug MozReview-Commit-ID: 2kqngXh1DYh
widget/TextEventDispatcher.cpp
widget/TextRange.h
widget/WidgetEventImpl.cpp
--- a/widget/TextEventDispatcher.cpp
+++ b/widget/TextEventDispatcher.cpp
@@ -590,17 +590,17 @@ TextEventDispatcher::PendingComposition:
   Clear();
 }
 
 void
 TextEventDispatcher::PendingComposition::Clear()
 {
   mString.Truncate();
   mClauses = nullptr;
-  mCaret.mRangeType = TextRangeType::NS_TEXTRANGE_UNDEFINED;
+  mCaret.mRangeType = TextRangeType::eUninitialized;
 }
 
 void
 TextEventDispatcher::PendingComposition::EnsureClauseArray()
 {
   if (mClauses) {
     return;
   }
--- a/widget/TextRange.h
+++ b/widget/TextRange.h
@@ -125,17 +125,17 @@ struct TextRangeStyle
 };
 
 /******************************************************************************
  * mozilla::TextRange
  ******************************************************************************/
 
 enum class TextRangeType : RawTextRangeType
 {
-  NS_TEXTRANGE_UNDEFINED = 0x00,
+  eUninitialized = 0x00,
   NS_TEXTRANGE_CARETPOSITION = 0x01,
   NS_TEXTRANGE_RAWINPUT =
     nsITextInputProcessor::ATTR_RAW_CLAUSE,
   NS_TEXTRANGE_SELECTEDRAWTEXT =
     nsITextInputProcessor::ATTR_SELECTED_RAW_CLAUSE,
   NS_TEXTRANGE_CONVERTEDTEXT =
     nsITextInputProcessor::ATTR_CONVERTED_CLAUSE,
   NS_TEXTRANGE_SELECTEDCONVERTEDTEXT =
@@ -147,17 +147,17 @@ RawTextRangeType ToRawTextRangeType(Text
 TextRangeType ToTextRangeType(RawTextRangeType aRawTextRangeType);
 const char* ToChar(TextRangeType aTextRangeType);
 
 struct TextRange
 {
   TextRange()
     : mStartOffset(0)
     , mEndOffset(0)
-    , mRangeType(TextRangeType::NS_TEXTRANGE_UNDEFINED)
+    , mRangeType(TextRangeType::eUninitialized)
   {
   }
 
   uint32_t mStartOffset;
   // XXX Storing end offset makes the initializing code very complicated.
   //     We should replace it with mLength.
   uint32_t mEndOffset;
 
--- a/widget/WidgetEventImpl.cpp
+++ b/widget/WidgetEventImpl.cpp
@@ -56,17 +56,17 @@ ToChar(EventClassID aEventClassID)
       return "illegal event class ID";
   }
 }
 
 bool
 IsValidRawTextRangeValue(RawTextRangeType aRawTextRangeType)
 {
   switch (static_cast<TextRangeType>(aRawTextRangeType)) {
-    case TextRangeType::NS_TEXTRANGE_UNDEFINED:
+    case TextRangeType::eUninitialized:
     case TextRangeType::NS_TEXTRANGE_CARETPOSITION:
     case TextRangeType::NS_TEXTRANGE_RAWINPUT:
     case TextRangeType::NS_TEXTRANGE_SELECTEDRAWTEXT:
     case TextRangeType::NS_TEXTRANGE_CONVERTEDTEXT:
     case TextRangeType::NS_TEXTRANGE_SELECTEDCONVERTEDTEXT:
       return true;
     default:
       return false;
@@ -85,18 +85,18 @@ ToTextRangeType(RawTextRangeType aRawTex
   MOZ_ASSERT(IsValidRawTextRangeValue(aRawTextRangeType));
   return static_cast<TextRangeType>(aRawTextRangeType);
 }
 
 const char*
 ToChar(TextRangeType aTextRangeType)
 {
   switch (aTextRangeType) {
-    case TextRangeType::NS_TEXTRANGE_UNDEFINED:
-      return "NS_TEXTRANGE_UNDEFINED";
+    case TextRangeType::eUninitialized:
+      return "TextRangeType::eUninitialized";
     case TextRangeType::NS_TEXTRANGE_CARETPOSITION:
       return "NS_TEXTRANGE_CARETPOSITION";
     case TextRangeType::NS_TEXTRANGE_RAWINPUT:
       return "NS_TEXTRANGE_RAWINPUT";
     case TextRangeType::NS_TEXTRANGE_SELECTEDRAWTEXT:
       return "NS_TEXTRANGE_SELECTEDRAWTEXT";
     case TextRangeType::NS_TEXTRANGE_CONVERTEDTEXT:
       return "NS_TEXTRANGE_CONVERTEDTEXT";