Bug 1411259 - Reduce mochitest tab process leak threshold to 0 on non-Windows platforms. r=erahm
authorAndrew McCreight <continuation@gmail.com>
Fri, 10 Nov 2017 01:48:49 +0200
changeset 444389 92f8f3e2d198cc60dd0e5d4f7e4fc65321903cce
parent 444388 39beeec35eccb3d38190a95cc50268ba7f7743d6
child 444390 54791453291c21807e995e63807b965708419ff3
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerserahm
bugs1411259
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1411259 - Reduce mochitest tab process leak threshold to 0 on non-Windows platforms. r=erahm Also, reduce the leak threshold on Windows.
testing/mochitest/mochitest_options.py
--- a/testing/mochitest/mochitest_options.py
+++ b/testing/mochitest/mochitest_options.py
@@ -826,21 +826,25 @@ class MochitestArguments(ArgumentContain
                         'Missing binary %s required for '
                         '--use-test-media-devices' % f)
 
         if options.nested_oop:
             options.e10s = True
 
         options.leakThresholds = {
             "default": options.defaultLeakThreshold,
-            "tab": 3000,  # See dependencies of bug 1401764.
+            "tab": options.defaultLeakThreshold,
             # GMP rarely gets a log, but when it does, it leaks a little.
             "geckomediaplugin": 20000,
         }
 
+        # See the dependencies of bug 1401764.
+        if mozinfo.isWin:
+            options.leakThresholds["tab"] = 1000
+
         # XXX We can't normalize test_paths in the non build_obj case here,
         # because testRoot depends on the flavor, which is determined by the
         # mach command and therefore not finalized yet. Conversely, test paths
         # need to be normalized here for the mach case.
         if options.test_paths and build_obj:
             # Normalize test paths so they are relative to test root
             options.test_paths = [build_obj._wrap_path_argument(p).relpath()
                                   for p in options.test_paths]