Bug 1156689: Add 'override' keyword to GetAsAudioInfo(), GetAsVideoInfo(), & Clone() on TrackInfo subclasses. rs=ehsan
authorDaniel Holbert <dholbert@cs.stanford.edu>
Sat, 02 May 2015 15:32:52 -0700
changeset 273528 92f70afc7a26d85844b40aa864836644a92c6dc3
parent 273527 b8af7eb3f5131d98e63a23792ca9c2a89b0a7ade
child 273529 c2fbd0459bab75df7b8c9ee86b76141663e354ad
push id863
push userraliiev@mozilla.com
push dateMon, 03 Aug 2015 13:22:43 +0000
treeherdermozilla-release@f6321b14228d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs1156689
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1156689: Add 'override' keyword to GetAsAudioInfo(), GetAsVideoInfo(), & Clone() on TrackInfo subclasses. rs=ehsan
dom/media/MediaInfo.h
--- a/dom/media/MediaInfo.h
+++ b/dom/media/MediaInfo.h
@@ -183,27 +183,27 @@ public:
   {
   }
 
   virtual bool IsValid() const override
   {
     return mDisplay.width > 0 && mDisplay.height > 0;
   }
 
-  virtual VideoInfo* GetAsVideoInfo()
+  virtual VideoInfo* GetAsVideoInfo() override
   {
     return this;
   }
 
-  virtual const VideoInfo* GetAsVideoInfo() const
+  virtual const VideoInfo* GetAsVideoInfo() const override
   {
     return this;
   }
 
-  virtual UniquePtr<TrackInfo> Clone() const
+  virtual UniquePtr<TrackInfo> Clone() const override
   {
     return MakeUnique<VideoInfo>(*this);
   }
 
   // Size in pixels at which the video is rendered. This is after it has
   // been scaled by its aspect ratio.
   nsIntSize mDisplay;
 
@@ -243,27 +243,27 @@ public:
   {
   }
 
   virtual bool IsValid() const override
   {
     return mChannels > 0 && mRate > 0;
   }
 
-  virtual AudioInfo* GetAsAudioInfo()
+  virtual AudioInfo* GetAsAudioInfo() override
   {
     return this;
   }
 
-  virtual const AudioInfo* GetAsAudioInfo() const
+  virtual const AudioInfo* GetAsAudioInfo() const override
   {
     return this;
   }
 
-  virtual UniquePtr<TrackInfo> Clone() const
+  virtual UniquePtr<TrackInfo> Clone() const override
   {
     return MakeUnique<AudioInfo>(*this);
   }
 
   // Sample rate.
   uint32_t mRate;
 
   // Number of audio channels.