Bug 1518996 - fix double border/outline for textbox[multiline] by not setting one on the inner textarea, r=jaws
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Fri, 11 Jan 2019 20:01:39 +0000
changeset 513513 92a30f1b817cba3154156a74bee123fc1af7b647
parent 513512 4195353da58d384a69466e622085c14354450347
child 513514 85cbb065250d22e6d4e34fa5db536603cb205fbd
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1518996
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1518996 - fix double border/outline for textbox[multiline] by not setting one on the inner textarea, r=jaws Differential Revision: https://phabricator.services.mozilla.com/D16334
toolkit/themes/shared/in-content/common.inc.css
--- a/toolkit/themes/shared/in-content/common.inc.css
+++ b/toolkit/themes/shared/in-content/common.inc.css
@@ -376,16 +376,23 @@ xul|textbox {
   border: 1px solid var(--in-content-box-border-color);
   border-radius: 2px;
   /* !important to override disabled styling from textbox.css. We reduce the
      opacity instead of changing colors. */
   color: inherit !important;
   background-color: var(--in-content-box-background) !important;
 }
 
+/* The focus/border styles for nested textareas inside textbox[multiline] will
+ * be provided by the textbox */
+xul|textbox[multiline] html|textarea {
+  border: none !important;
+  box-shadow: none !important;
+}
+
 xul|textbox {
   min-height: 30px;
   padding-right: 8px;
   padding-left: 8px;
 }
 
 /* Create a separate rule to unset these styles on .tree-input instead of
    using :not(.tree-input) so the selector specifity doesn't change. */